Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Re-enable flaky kubectl plugin e2e test in kubectl_ray_job_submit_test.go #2801

Closed
2 tasks done
MortalHappiness opened this issue Jan 22, 2025 · 1 comment · Fixed by #3124
Closed
2 tasks done

[Bug] Re-enable flaky kubectl plugin e2e test in kubectl_ray_job_submit_test.go #2801

MortalHappiness opened this issue Jan 22, 2025 · 1 comment · Fixed by #3124
Assignees
@MortalHappiness @owenowenisme
Labels
bug Something isn't working cli kubectl plugin P0 Critical issue that should be fixed ASAP

Comments

@MortalHappiness
Copy link
Member

MortalHappiness commented Jan 22, 2025 •
edited
Loading

Search before asking

  • I searched the issues and found no similar issues.

KubeRay Component

ray-operator

What happened + What you expected to happen

#2800 temporarily disabled this flaky test. Try to fix it and re-enable it.

kuberay/kubectl-plugin/test/e2e/kubectl_ray_job_submit_test.go

Line 34 in 4bb1226

Skip("Skip this test as it is failing on CI")

kuberay/kubectl-plugin/test/e2e/kubectl_ray_job_submit_test.go

Line 70 in 4bb1226

Skip("Skip this test as it is failing on CI")

Possibly related to #2758

Reproduction script

N/A

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@MortalHappiness MortalHappiness added bug Something isn't working cli kubectl plugin labels Jan 22, 2025
@MortalHappiness MortalHappiness self-assigned this Jan 22, 2025
@MortalHappiness MortalHappiness mentioned this issue Jan 22, 2025
Merged
4 tasks
@kevin85421 kevin85421 added 1.3.0 P0 Critical issue that should be fixed ASAP labels Jan 22, 2025
@owenowenisme
Copy link
Contributor

Also take this one.

@owenowenisme owenowenisme mentioned this issue Feb 27, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MortalHappiness MortalHappiness

@owenowenisme owenowenisme

Labels
bug Something isn't working cli kubectl plugin P0 Critical issue that should be fixed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bug] Re-enable flaky kubectl plugin e2e test in kubectl_ray_job_submit_test.go owenowenisme/kuberay
3 participants
@kevin85421 @MortalHappiness @owenowenisme