Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rapidsai/ucxx
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 08e271df1482b1990dfecc91236c843fa88529f5
Choose a base ref
..
head repository: rapidsai/ucxx
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2a89d6f8076237b19944fb9474e8fa9907923248
Choose a head ref
Showing with 7 additions and 1 deletion.
  1. +3 −1 ci/test_python.sh
  2. +4 −0 python/distributed-ucxx/distributed_ucxx/tests/test_ucx.py
4 changes: 3 additions & 1 deletion ci/test_python.sh
View file
Original file line number Diff line number Diff line change
@@ -22,6 +22,7 @@ conda activate test
# mode to provide test utils, but that's probably not doable from conda packages.
rapids-logger "Install Dask and Distributed"
pip install git+https://github.com/dask/dask@main
rm -rf /tmp/distributed
git clone https://github.com/dask/distributed /tmp/distributed
pip install -e /tmp/distributed

@@ -84,11 +85,12 @@ run_distributed_ucxx_tests() {
ENABLE_DELAYED_SUBMISSION=$2
ENABLE_PYTHON_FUTURE=$3

CMD_LINE="UCXPY_PROGRESS_MODE=${PROGRESS_MODE} UCXPY_ENABLE_DELAYED_SUBMISSION=${ENABLE_DELAYED_SUBMISSION} UCXPY_ENABLE_PYTHON_FUTURE=${ENABLE_PYTHON_FUTURE} timeout 10m python -vs python/distributed-ucxx/distributed_ucxx/tests/"
CMD_LINE="UCXPY_PROGRESS_MODE=${PROGRESS_MODE} UCXPY_ENABLE_DELAYED_SUBMISSION=${ENABLE_DELAYED_SUBMISSION} UCXPY_ENABLE_PYTHON_FUTURE=${ENABLE_PYTHON_FUTURE} timeout 10m pytest -vs python/distributed-ucxx/distributed_ucxx/tests/"

# Workaround for https://github.com/rapidsai/ucxx/issues/15
# CMD_LINE="UCX_KEEPALIVE_INTERVAL=1ms ${CMD_LINE}"

log_command "${CMD_LINE}"
UCXPY_PROGRESS_MODE=${PROGRESS_MODE} UCXPY_ENABLE_DELAYED_SUBMISSION=${ENABLE_DELAYED_SUBMISSION} UCXPY_ENABLE_PYTHON_FUTURE=${ENABLE_PYTHON_FUTURE} timeout 10m pytest -vs python/distributed-ucxx/distributed_ucxx/tests/
}

4 changes: 4 additions & 0 deletions python/distributed-ucxx/distributed_ucxx/tests/test_ucx.py
View file
Original file line number Diff line number Diff line change
@@ -393,6 +393,10 @@ async def test_ucxx_protocol(ucxx_loop, cleanup, port):


@gen_test()
@pytest.mark.skipif(
int(os.environ.get("UCXPY_ENABLE_PYTHON_FUTURE", "1")) != 0,
reason="Segfaults when Python futures are enabled",
)
async def test_ucxx_unreachable(
ucxx_loop,
):