Skip to content

Commit 4eca5b3

Browse files
authored
rename python-lit feature to cccl-dev (#113)
* rename python-lit to cccl-dev * rename directory * rename lit -> cccl_dev in matrix.yaml * update docs * rename directory * fix comparison
1 parent 0505f78 commit 4eca5b3

File tree

14 files changed

+40
-40
lines changed

14 files changed

+40
-40
lines changed

DEVELOP.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ This repository defines features to install the following dev tools, compilers,
1616
* [ninja-build](features/src/ninja/)
1717
* [NVIDIA HPC SDK](features/src/nvhpc/)
1818
* [Intel OneAPI compilers](features/src/oneapi/)
19-
* [lit (from pypi)](features/src/python-lit/)
19+
* [CCCL development utilities](features/src/cccl-dev/)
2020
* [Rust](features/src/rust/)
2121
* [sccache](features/src/sccache/)
2222
* [devcontainer-utils](features/src/utils/)
File renamed without changes.
File renamed without changes.

features/src/python-lit/devcontainer-feature.json features/src/cccl-dev/devcontainer-feature.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
2-
"name": "python-lit testing framework",
3-
"id": "python-lit",
4-
"version": "23.10.1",
5-
"description": "A feature to install python-lit",
2+
"name": "NVIDIA CCCL development utilities",
3+
"id": "cccl-dev",
4+
"version": "23.10.0",
5+
"description": "A feature to install NVIDIA CCCL development utilities",
66
"options": {
7-
"version": {
7+
"litVersion": {
88
"type": "string",
99
"proposals": [
1010
"latest",

features/src/python-lit/install.sh features/src/cccl-dev/install.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#! /usr/bin/env bash
22
set -ex
33

4-
LIT_VERSION="${VERSION:-latest}";
4+
LIT_VERSION="${LITVERSION:-latest}";
55

66
if [ "$LIT_VERSION" -neq "latest" ]; then
77
LIT_VERSION_TO_INSTALL="lit==$LIT_VERSION"
@@ -20,7 +20,7 @@ if ! type python >/dev/null 2>&1; then
2020
exit 1;
2121
fi
2222

23-
PKG=("gettext-base");
23+
PKG=("gettext-base" "libtbb-dev");
2424
PKG_TO_REMOVE=();
2525

2626
# Install gcc and g++ because we have to build psutil wheel for non-x86
@@ -40,7 +40,7 @@ export LIT_VERSION="$(lit --version | grep -o -e '[0-9].*')";
4040
append_to_etc_bashrc "$(cat .bashrc | envsubst '$LIT_VERSION')";
4141
append_to_all_bashrcs "$(cat .bashrc | envsubst '$LIT_VERSION')";
4242
# export envvars in /etc/profile.d
43-
add_etc_profile_d_script python-lit "$(cat .bashrc | envsubst '$LIT_VERSION')";
43+
add_etc_profile_d_script cccl-dev "$(cat .bashrc | envsubst '$LIT_VERSION')";
4444

4545
# Clean up
4646
# rm -rf /tmp/*;

features/src/utils/devcontainer-feature.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "devcontainer-utils",
33
"id": "utils",
4-
"version": "23.10.2",
4+
"version": "23.10.3",
55
"description": "A feature to install RAPIDS devcontainer utility scripts",
66
"containerEnv": {
77
"BASH_ENV": "/etc/bash.bash_env"

features/src/utils/opt/devcontainer/bin/post-attach-command.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#! /usr/bin/env bash
22

33
find ~/ -maxdepth 1 -exec bash -c "\
4-
[ \$(stat --format '%U:%G' '{}') != $(id -u):$(id -g) ] \
4+
[ \$(stat --format '%u:%g' '{}') != $(id -u):$(id -g) ] \
55
&& sudo chown -R $(id -u):$(id -g) {}" \;
66

77
. devcontainer-utils-init-git;

features/test/python-lit/py3_10.sh features/test/cccl-dev/py3_10.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# This test can be run with the following command (from the root of this repo)
44
# ```
55
# npx --package=@devcontainers/cli -c 'devcontainer features test \
6-
# --features python-lit \
6+
# --features cccl-dev \
77
# --base-image ubuntu:22.04 .'
88
# ```
99

features/test/python-lit/scenarios.json features/test/cccl-dev/scenarios.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
"image": "ubuntu:22.04",
44
"features": {
55
"ghcr.io/devcontainers/features/python:1": {},
6-
"python-lit": {}
6+
"cccl-dev": {}
77
},
88
"overrideFeatureInstallOrder": [
99
"ghcr.io/devcontainers/features/python",
10-
"./python-lit"
10+
"./cccl-dev"
1111
]
1212
}
1313
}

matrix.yml

+26-26
Original file line numberDiff line numberDiff line change
@@ -34,44 +34,44 @@ x-rust: &rust { name: "rust" }
3434
x-mambaforge: &conda { name: "mambaforge" }
3535

3636
x-python: &python { name: "ghcr.io/devcontainers/features/python:1", hide: true }
37-
x-lit: &lit { name: "python-lit", hide: true }
37+
x-cccl_dev: &cccl_dev { name: "cccl-dev", hide: true }
3838

3939
include:
4040
# CCCL devcontainers
4141

4242
- os: "ubuntu:18.04"
4343
images:
44-
- {features: [*gcc_6, *cuda_prev_min, *python, *lit], env: *gcc_env}
45-
- {features: [*gcc_7, *cuda_prev_min, *python, *lit], env: *gcc_env}
46-
- {features: [*gcc_8, *cuda_prev_min, *python, *lit], env: *gcc_env}
47-
- {features: [*gcc_9, *cuda_prev_min, *python, *lit], env: *gcc_env}
48-
- {features: [*llvm_9, *cuda_prev_min, *python, *lit], env: *llvm_env}
49-
- {features: [*oneapi_2022, *cuda_prev_min, *python, *lit], env: *onapi_env}
44+
- {features: [*gcc_6, *cuda_prev_min, *python, *cccl_dev], env: *gcc_env}
45+
- {features: [*gcc_7, *cuda_prev_min, *python, *cccl_dev], env: *gcc_env}
46+
- {features: [*gcc_8, *cuda_prev_min, *python, *cccl_dev], env: *gcc_env}
47+
- {features: [*gcc_9, *cuda_prev_min, *python, *cccl_dev], env: *gcc_env}
48+
- {features: [*llvm_9, *cuda_prev_min, *python, *cccl_dev], env: *llvm_env}
49+
- {features: [*oneapi_2022, *cuda_prev_min, *python, *cccl_dev], env: *onapi_env}
5050

5151
- os: "ubuntu:20.04"
5252
images:
53-
- {features: [*gcc_7, *cuda_curr_max, *python, *lit], env: *gcc_env}
54-
- {features: [*gcc_8, *cuda_curr_max, *python, *lit], env: *gcc_env}
55-
- {features: [*gcc_9, *cuda_curr_max, *python, *lit], env: *gcc_env}
56-
- {features: [*gcc_10, *cuda_curr_max, *python, *lit], env: *gcc_env}
57-
- {features: [*llvm_9, *cuda_curr_max, *python, *lit], env: *llvm_env}
58-
- {features: [*llvm_10, *cuda_curr_max, *python, *lit], env: *llvm_env}
59-
- {features: [*llvm_11, *cuda_curr_max, *python, *lit], env: *llvm_env}
60-
- {features: [*llvm_12, *cuda_curr_max, *python, *lit], env: *llvm_env}
61-
- {features: [*llvm_13, *cuda_curr_max, *python, *lit], env: *llvm_env}
62-
- {features: [*llvm_14, *cuda_curr_max, *python, *lit], env: *llvm_env}
63-
- {features: [*oneapi_2022, *cuda_curr_max, *python, *lit], env: *onapi_env}
53+
- {features: [*gcc_7, *cuda_curr_max, *python, *cccl_dev], env: *gcc_env}
54+
- {features: [*gcc_8, *cuda_curr_max, *python, *cccl_dev], env: *gcc_env}
55+
- {features: [*gcc_9, *cuda_curr_max, *python, *cccl_dev], env: *gcc_env}
56+
- {features: [*gcc_10, *cuda_curr_max, *python, *cccl_dev], env: *gcc_env}
57+
- {features: [*llvm_9, *cuda_curr_max, *python, *cccl_dev], env: *llvm_env}
58+
- {features: [*llvm_10, *cuda_curr_max, *python, *cccl_dev], env: *llvm_env}
59+
- {features: [*llvm_11, *cuda_curr_max, *python, *cccl_dev], env: *llvm_env}
60+
- {features: [*llvm_12, *cuda_curr_max, *python, *cccl_dev], env: *llvm_env}
61+
- {features: [*llvm_13, *cuda_curr_max, *python, *cccl_dev], env: *llvm_env}
62+
- {features: [*llvm_14, *cuda_curr_max, *python, *cccl_dev], env: *llvm_env}
63+
- {features: [*oneapi_2022, *cuda_curr_max, *python, *cccl_dev], env: *onapi_env}
6464

6565
- os: "ubuntu:22.04"
6666
images:
67-
- {features: [*nvhpc_prev, *python, *lit], env: *nvhpc_env}
68-
- {features: [*nvhpc_curr, *python, *lit], env: *nvhpc_env}
69-
- {features: [*gcc_11, *cuda_curr_max, *python, *lit], env: *gcc_env}
70-
- {features: [*gcc_12, *cuda_curr_max, *python, *lit], env: *gcc_env}
71-
- {features: [*llvm_15, *cuda_curr_max, *python, *lit], env: *llvm_env}
72-
- {features: [*llvm_prev, *cuda_curr_max, *python, *lit], env: *llvm_env}
73-
- {features: [*llvm_curr, *cuda_curr_max, *python, *lit], env: *llvm_env}
74-
- {features: [*oneapi_2022, *cuda_curr_max, *python, *lit], env: *onapi_env}
67+
- {features: [*nvhpc_prev, *python, *cccl_dev], env: *nvhpc_env}
68+
- {features: [*nvhpc_curr, *python, *cccl_dev], env: *nvhpc_env}
69+
- {features: [*gcc_11, *cuda_curr_max, *python, *cccl_dev], env: *gcc_env}
70+
- {features: [*gcc_12, *cuda_curr_max, *python, *cccl_dev], env: *gcc_env}
71+
- {features: [*llvm_15, *cuda_curr_max, *python, *cccl_dev], env: *llvm_env}
72+
- {features: [*llvm_prev, *cuda_curr_max, *python, *cccl_dev], env: *llvm_env}
73+
- {features: [*llvm_curr, *cuda_curr_max, *python, *cccl_dev], env: *llvm_env}
74+
- {features: [*oneapi_2022, *cuda_curr_max, *python, *cccl_dev], env: *onapi_env}
7575

7676
# RAPIDS devcontainers
7777

0 commit comments

Comments
 (0)