Skip to content

Commit 2adc059

Browse files
authored
handle more RAPIDS version formats in update-version.sh (#1307)
Contributes to rapidsai/build-planning#13. Updates `update-version.sh` to correctly handle RAPIDS dependencies like `cudf-cu12==24.2.*`. This project doesn't appear to have any of those right now, but might in the future. ### How I tested this The portability of this updated `sed` command was tested here: rapidsai/cudf#14825 (comment). In this repo, I ran the following: ```shell ./ci/release/update-version.sh '23.10.00' git diff ./ci/release/update-version.sh '24.04.00' git diff ``` Confirmed that that first `git diff` changed all the things I expected, and that second one showed 0 changes. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Ray Douglass (https://github.com/raydouglass) URL: #1307
1 parent 897f0b6 commit 2adc059

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

ci/release/update-version.sh

+13-5
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,21 @@ function sed_runner() {
3535
# Centralized version file update
3636
echo "${NEXT_FULL_TAG}" | tr -d '"' > VERSION
3737

38-
# Bump cudf and dask-cudf testing dependencies
39-
sed_runner "s/cudf==.*/cudf==${NEXT_SHORT_TAG_PEP440}.*/g" dependencies.yaml
40-
sed_runner "s/dask-cudf==.*/dask-cudf==${NEXT_SHORT_TAG_PEP440}.*/g" dependencies.yaml
41-
sed_runner "s/kvikio==.*/kvikio==${NEXT_SHORT_TAG_PEP440}.*/g" dependencies.yaml
38+
# Bump testing dependencies
4239
sed_runner "s/ucx-py==.*/ucx-py==${NEXT_UCXPY_VERSION}.*/g" dependencies.yaml
4340
sed_runner "s/ucxx==.*/ucxx==${NEXT_UCXPY_VERSION}.*/g" dependencies.yaml
44-
sed_runner "s/rapids-dask-dependency==.*/rapids-dask-dependency==${NEXT_SHORT_TAG_PEP440}.*/g" dependencies.yaml
41+
42+
DEPENDENCIES=(
43+
cudf
44+
dask-cudf
45+
kvikio
46+
rapids-dask-dependency
47+
)
48+
for FILE in dependencies.yaml conda/environments/*.yaml; do
49+
for DEP in "${DEPENDENCIES[@]}"; do
50+
sed_runner "/-.* ${DEP}\(-cu[[:digit:]]\{2\}\)\{0,1\}==/ s/==.*/==${NEXT_SHORT_TAG_PEP440}.*/g" "${FILE}"
51+
done
52+
done
4553

4654
# CI files
4755
for FILE in .github/workflows/*.yaml; do

0 commit comments

Comments
 (0)