Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render slow with fish #576

Closed
superiums opened this issue Jul 28, 2024 · 8 comments
Closed

render slow with fish #576

superiums opened this issue Jul 28, 2024 · 8 comments

Comments

@superiums
Copy link

it works well with sh or bash, but very slow with fish.
even a ls command takes about 2-3 seconds.

@mervyn-mccreight
Copy link

Can't reproduce that on my machine 🤔

I'm using fish as well (on MacOS) with rioterm 0.1.3 and I can't see any differences performance wise to other shells.

Have you checked if fish runs smoothly in other terminals?

@avelino
Copy link
Contributor

avelino commented Aug 2, 2024

I use fish and I'm not experiencing this slowness, it would be important to share more information

  • rio config
  • fish config
  • rio version

@superiums
Copy link
Author

rio --version
rioterm 0.1.1

os: both void-linux and arch . both slow.

rio config with default.
fish config:

if status is-interactive
    # if status is-login
    set -x VDPAU_DRIVER radeonsi
    # set -x OPENCV_LOG_LEVEL ERROR
    set -x PUPPETEER_EXECUTABLE_PATH /usr/bin/chromium
    set -x JAVA_HOME /usr/lib/jvm/default
    # set -x NODE_PATH "/opt/code/depot/node_global/lib/node_modules/"
    set -x NODE_PATH /opt/code/depot/node_global/pnpm_dir/5/node_modules
    set -x PNPM_HOME /opt/code/depot/node_global/pnpm_bin
    set -x SciTE_USERHOME ~/.config/scite
    set -x PATH $PATH $PNPM_HOME
    set -x PATH $PATH /opt/code/depot/node_global/bin/
    set -x PATH $PATH $JAVA_HOME/bin
    set -x PATH $PATH "$HOME/.local/bin"
    set -x V2RAY_LOCATION_ASSET /etc/v2ray
    set -x EDITOR /usr/bin/hx
    # set -x TERMINAL /usr/bin/foot #for mimeopen
    # set -x LF_DATA_HOME /tmp
    # set -x LF_BOOKMARK_PATH ~/.config/lf/
    abbr -a -g -- xi 'sudo xbps-install'
    abbr -a -g -- xup 'sudo xbps-install -Su'
    abbr -a -g -- xq 'xbps-query -s'
    abbr -a -g -- xs 'xbps-query -Rs'
    abbr -a -g -- xr 'sudo xbps-remove -R'
    ### ALIASES ###
    # navigation
    alias ..='cd ..'
    alias ...='cd ../..'
    alias .3='cd ../../..'
    alias .4='cd ../../../..'
    alias .5='cd ../../../../..'

    # ps
    alias psa="ps auxf"
    alias psgrep="ps aux | grep -v grep | grep -i -e VSZ -e"
    alias psmem='ps auxf | sort -nr -k 4'
    alias pscpu='ps auxf | sort -nr -k 3'

    # fzf

    set -x FZF_DEFAULT_COMMAND "fd --type f --exclude={.git,.vscode,node_modules,build}"
    # set -x FZF_DEFAULT_OPTS "--height 40% --preview 'highlight -O ansi -l {} 2>/dev/null'"
    set -x FZF_DEFAULT_OPTS "--height 40% --preview 'bat -n --color=always {}'"
    # set -x FZF_DEFAULT_OPTS "--height 40% --layout=reverse --preview '(highlight {} || cat {}) 2> /dev/null | head -500'"
    # alias fzfp="fzf --preview 'highlight -O ansi -l {} 2>/dev/null'"
    # z
    zoxide init fish | source

    # lesspipe
    set -x LESS -R
    set -x LESSOPEN '|/usr/bin/lesspipe.sh %s'
    set -x LESS_ADVANCED_PREPROCESSOR 1
    # set -x LESSCOLORIZER 'highlight -O ansi'
    set -x LESSCOLORIZE code2color

    # browser
    alias thorium='thorium-browser --disk-cache-dir=/tmp/thorium'
    alias chromium='chromium --disk-cache-dir=/tmp/chromium'


end

# bun
set --export BUN_INSTALL /opt/code/bun
set --export PATH $BUN_INSTALL/bin $PATH

eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)"

@raphamorim
Copy link
Owner

Thanks for the issue @superiums!

Are you using Rio with wayland?

@superiums
Copy link
Author

yes, with wayland.
and amd gpu

@raphamorim
Copy link
Owner

do you have x11 enabled as well to test? wondering if is an issue with rio wayland

@raphamorim
Copy link
Owner

@superiums could you test again with v0.1.6?

@raphamorim
Copy link
Owner

I am closing this issue for now since from v0.1.3 to v0.1.16 the renderer logic has positively suffered many updates in performances. Please lemme know anything and I can reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants