Skip to content

Commit 3a9bfdb

Browse files
author
Dennis Schmidt & Sheel Choksi
committed
remove clouseau (framework detection), update gem dependents
1 parent 6528cdb commit 3a9bfdb

File tree

10 files changed

+19
-210
lines changed

10 files changed

+19
-210
lines changed

Gemfile

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ gem "rake"
1010

1111
gem "interact", :git => "git://github.com/vito/interact.git"
1212
gem "cfoundry", :git => "git://github.com/cloudfoundry/cfoundry.git", :submodules => true
13-
gem "clouseau", :git => "git://github.com/vito/clouseau.git"
1413
gem "mothership", :git => "git://github.com/vito/mothership.git"
1514

1615
gem "admin-cf-plugin", :git => "git://github.com/cloudfoundry/admin-cf-plugin.git"

Gemfile.lock

+16-24
Original file line numberDiff line numberDiff line change
@@ -1,59 +1,52 @@
11
GIT
22
remote: git://github.com/cloudfoundry/admin-cf-plugin.git
3-
revision: ca5a4ae481def9b550b89733cb23e441f4917ee4
3+
revision: b911e17af3f77d20f1b267bf5b051c490e052f0a
44
specs:
5-
admin-cf-plugin (0.2.0.rc1)
6-
cfoundry (>= 0.6.0.rc1, < 0.7)
5+
admin-cf-plugin (0.2.0.rc2)
6+
cfoundry (>= 0.5.3.rc6, < 0.6)
77

88
GIT
99
remote: git://github.com/cloudfoundry/cfoundry.git
10-
revision: 049f9f70842ffee4c6d60c2d8d000f6dd7647e7e
10+
revision: efcbc10041ee1e0bb0b4e41261e71f7a9fddd272
1111
submodules: true
1212
specs:
13-
cfoundry (0.6.0.rc2)
13+
cfoundry (0.6.0.rc5)
1414
cf-uaa-lib (~> 1.3.10)
1515
multi_json (~> 1.3)
1616
multipart-post (~> 1.1)
1717
rubyzip (~> 0.9)
1818

1919
GIT
2020
remote: git://github.com/cloudfoundry/console-cf-plugin.git
21-
revision: af02d02fb272d758037121be207ce71bb989fd44
21+
revision: fcfd4eb362d5a041d5f101c24bfef84ec679fa22
2222
specs:
23-
console-cf-plugin (0.2.0.rc1)
24-
tunnel-cf-plugin (>= 0.3.0.rc1, < 0.4)
23+
console-cf-plugin (0.2.0.rc3)
24+
tunnel-cf-plugin (>= 0.3.0.rc2, < 0.4)
2525

2626
GIT
2727
remote: git://github.com/cloudfoundry/manifests-cf-plugin.git
28-
revision: a405fe289d71290dbd13d05093806af359f7d43c
28+
revision: 05f2ef1db7f1a148c721e0717b2205644e17afad
2929
specs:
30-
manifests-cf-plugin (0.7.0.rc1)
31-
cfoundry (>= 0.6.0.rc1, < 0.7)
30+
manifests-cf-plugin (0.7.0.rc2)
31+
cfoundry (>= 0.5.3.rc6, < 0.6)
3232

3333
GIT
3434
remote: git://github.com/cloudfoundry/micro-cf-plugin.git
35-
revision: 758f9572a0a253457ae7e3c13ffa2282a4bf08bb
35+
revision: 6e80930e9b8fe67d21245e2ba9d92cec1f6213bb
3636
specs:
37-
micro-cf-plugin (0.1.0.rc1)
37+
micro-cf-plugin (0.1.0.rc2)
3838

3939
GIT
4040
remote: git://github.com/cloudfoundry/tunnel-cf-plugin.git
41-
revision: f6d2690acef1ceb11949de30b4b9d9068e9569d6
41+
revision: 8f548007cede3662a4921976dc51de4e421e3a80
4242
specs:
4343
tunnel-cf-plugin (0.3.0.rc2)
4444
addressable (~> 2.2)
4545
caldecott-client (~> 0.0.2)
46-
cfoundry (>= 0.6.0.rc2, < 0.7)
46+
cfoundry (>= 0.5.3.rc6, < 0.6)
4747
rest-client (~> 1.6)
4848
uuidtools (~> 2.1)
4949

50-
GIT
51-
remote: git://github.com/vito/clouseau.git
52-
revision: af05617556504c436901d43edc76f6578f363b83
53-
specs:
54-
clouseau (0.0.1)
55-
rubyzip (~> 0.9.9)
56-
5750
GIT
5851
remote: git://github.com/vito/interact.git
5952
revision: 956058c9c1c03f9b606fb7f45e598edfdfa0a20e
@@ -81,7 +74,7 @@ GEM
8174
gem-release (0.4.1)
8275
json_pure (1.7.7)
8376
mime-types (1.21)
84-
multi_json (1.7.1)
77+
multi_json (1.7.2)
8578
multipart-post (1.2.0)
8679
parallel (0.6.2)
8780
parallel_tests (0.10.0)
@@ -110,7 +103,6 @@ PLATFORMS
110103
DEPENDENCIES
111104
admin-cf-plugin!
112105
cfoundry!
113-
clouseau!
114106
console-cf-plugin!
115107
fakefs
116108
ffaker

cf.gemspec

+1-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ Gem::Specification.new do |s|
2828
s.add_runtime_dependency "multi_json", "~> 1.3"
2929

3030
s.add_runtime_dependency "interact", "~> 0.5"
31-
s.add_runtime_dependency "cfoundry", ">= 0.5.3.rc5", "< 0.6"
32-
s.add_runtime_dependency "clouseau", "~> 0.0"
31+
s.add_runtime_dependency "cfoundry", ">= 0.6.0.rc4", "< 0.7"
3332
s.add_runtime_dependency "mothership", ">= 0.5.1", "< 1.0"
3433
s.add_runtime_dependency "manifests-cf-plugin", ">= 0.7.0.rc2", "< 0.8"
3534
s.add_runtime_dependency "tunnel-cf-plugin", ">= 0.3.0.rc2", "< 0.4"

lib/cf/cli/app/push/create.rb

+1-10
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
require "cf/detect"
2-
31
module CF::App
42
module Create
53
attr_accessor :input
@@ -16,10 +14,7 @@ def get_inputs
1614
inputs[:buildpack] = input[:buildpack]
1715
inputs[:command] = input[:command] if input.has?(:command) || !has_procfile?
1816

19-
detected = detector.detected
20-
human_mb = human_mb((detected && detected.memory_suggestion) || 64)
21-
inputs[:memory] = megabytes(input[:memory, human_mb])
22-
17+
inputs[:memory] = megabytes(input[:memory, human_mb(256)])
2318
inputs[:stack] = input[:stack]
2419

2520
inputs
@@ -105,10 +100,6 @@ def all_instances
105100
@all_instances ||= client.service_instances
106101
end
107102

108-
def detector
109-
@detector ||= CF::Detector.new(client, @path)
110-
end
111-
112103
def target_base
113104
client.target.sub(/^https?:\/\/([^\.]+\.)?(.+)\/?/, '\2')
114105
end

lib/cf/cli/service/bind.rb

-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
require "cf/detect"
2-
31
require "cf/cli/service/base"
42

53
module CF::Service

lib/cf/cli/service/unbind.rb

-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
require "cf/detect"
2-
31
require "cf/cli/service/base"
42

53
module CF::Service

lib/cf/detect.rb

-129
This file was deleted.

spec/cf/cli/app/push/create_spec.rb

-5
Original file line numberDiff line numberDiff line change
@@ -151,11 +151,6 @@
151151
memory_choices = %w(64M 128M 256M 512M 1G)
152152
stub(create).memory_choices { memory_choices }
153153

154-
detector = mock
155-
stub(create).detector { detector }
156-
157-
stub(detector).detected { Clouseau::Rails }
158-
159154
mock_ask('Memory Limit', anything) do |_, options|
160155
expect(options[:choices]).to eq memory_choices
161156
expect(options[:default]).to eq "256M"

spec/cf/detect_spec.rb

-34
This file was deleted.

spec/features/account_lifecycle_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
end
3232

3333
it "registers a new account and deletes it" do
34-
pending "until we get some v2 admin credentials somewhere to actually run this with" if TRAVIS_BUILD_ID
34+
pending "until we get some v2 admin credentials somewhere to actually run this with"
3535

3636
email = Faker::Internet.email
3737
run("#{cf_bin} target #{target}") do |runner|

0 commit comments

Comments
 (0)