feat: uv support, py 3.13 #1216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeCooper
reviewed
Nov 8, 2024
coffee-cup
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Looking good! Agree with @JakeCooper about adding an example (examples/python-uv) to test the plan generation for this update
src/providers/python.rs
Outdated
Comment on lines
122
to
129
| plan.add_variables(EnvironmentVariables::from([( | ||
| "NIXPACKS_UV_VERSION".to_string(), | ||
| version, | ||
| )])); | ||
|
|
||
| plan.add_variables(EnvironmentVariables::from([( | ||
| "UV_PROJECT_ENVIRONMENT".to_string(), | ||
| VENV_LOCATION.to_string(), | ||
| )])); | ||
| } |
There was a problem hiding this comment.
suggestion: you can add these in a single command
iloveitaly
force-pushed
the
uv-support
branch
from
5b8f9c1
to
fbbfc40
Compare
- Changed the PYTHON_NIXPKGS_ARCHIVE to a new hash. - Updated PostgreSQL package to require the .dev variant for compatibility with psycopg2. - Added comments to clarify the changes for future reference.
iloveitaly
force-pushed
the
uv-support
branch
from
7dfb70b
to
27d6f6d
Compare
- Add `snapshot_kind: text` to snapshots - Change `postgresql` to `postgresql.dev` in dependencies
|
Alright, build is finally passing here. I needed to make some additional updates to properly support the latest nixpkgs version (which included py 3.13). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curious what you think of this approach to supporting uv. Happy to add some tests for this as well, wanted to check on the approach before I built out the tests.
Fixes: #1128