Skip to content
This repository was archived by the owner on Jul 27, 2023. It is now read-only.

View Submodule #54

Open
FintanH opened this issue Jan 15, 2020 · 0 comments
Open

View Submodule #54

FintanH opened this issue Jan 15, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@FintanH
Copy link
Collaborator

FintanH commented Jan 15, 2020

Currently we have to skip over a submodule if it appears in a directory tree.

The issue is that when we get a TreeEntry for a submodule and check its ObjectType it appears to be a Commit.

When trying to render a directory tree we to_object which takes the Repository that should have that object. Thus, the function will return an Error since it cannot find the Commit for the submodule in the repository.

In GitHub a submodule is rendered as a link to the submodule's URL. Would this be possible in surf?
@FintanH FintanH added enhancement New feature or request help wanted Extra attention is needed labels Jan 15, 2020
@FintanH FintanH added the good first issue Good for newcomers label Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FintanH