Skip to content
This repository was archived by the owner on Jul 27, 2023. It is now read-only.

Potential types to be exported #41

Open
xla opened this issue Dec 16, 2019 · 0 comments
Open

Potential types to be exported #41

xla opened this issue Dec 16, 2019 · 0 comments
Labels
discussion enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@xla
Copy link
Contributor

xla commented Dec 16, 2019

This issue is to track the types and information we need frequently and could become first class in surf instead of reaching down to git2.

  • Author/Person/Signer/Commiter/Tagger
    • name
    • email
  • Commit
    • oid/SHA1
    • isBinary
    • file content
    • summary
    • message
    • time
    • author(s)/signer(s)
  • Branch
    • name
    • oid/sha1
  • Tag
    • name
    • oidsha1
    • potentially info of a full tag

@FintanH Lemme know if something is unclear or missing. <3
@xla xla mentioned this issue Dec 16, 2019
Merged
@xla xla added discussion enhancement New feature or request labels Dec 16, 2019
xla added a commit to radicle-dev/radicle-upstream that referenced this issue Dec 18, 2019
@xla
Integrate radicle-surf to satisfy CoCo API endpoints (#64)
bc9b818 
This change introduces an implementation of the API drafted for #55
powered by radicle-dev/radicle-surf. A couple of adjustments had to be
made to surf along the way. Most notably we needed to reexport git2 to
have access to some lower level types. We track types and their info we
depend on in radicle-dev/radicle-surf#41 to remedy that. We also settled
on git-platinum as the body of fixtures to be used in our tests. The
infrastructure to test GraphQL queries has been drastically improved in
this patch and is expected to be more exhaustive with additions, as well
as the discovery of edge cases.

At the time of this writing there is a incosnistency in how
`last_commit` behaves, it is tracked in radicle-dev/radicle-surf#40.
This means the API will always return the latest commit for the current
history, indiscriminate if it touched the path in question - Resulting
in errors in the ui integration tests.

* implement branches query
* implement tags query
* implement commit query
* implement blob query
* implement tree query
* integrate API in the UI
* use radicle-dev/git-platinum for test fixtures
* use latest compatible toolchain (dictated by radicle-dev/radicle-registry)
* pull in radicle-dev/radicle-surf as dependency

Resolves MON-10
@FintanH FintanH added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
discussion enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xla @FintanH