Avoid somewhat complicated if logic.

Author: lukebakken

dotnet/PublisherConfirms/PublisherConfirms.cs

@@ -1,7 +1,7 @@
-using System.Buffers.Binary;
+using RabbitMQ.Client;
+using System.Buffers.Binary;
 using System.Diagnostics;
 using System.Text;
-using RabbitMQ.Client;
 
 const ushort MAX_OUTSTANDING_CONFIRMS = 256;
 
@@ -94,27 +94,34 @@ async Task PublishMessagesInBatchAsync()
         ValueTask publishTask = channel.BasicPublishAsync(exchange: string.Empty, routingKey: queueName, body: body, mandatory: true, basicProperties: props);
         publishTasks.Add(publishTask);
 
-        // NOTE: [publishTasks] should be published after the final message has been added,
-        // even if the # of tasks it contains isn't equal to [batchSize].
-        if (publishTasks.Count == batchSize || i+1 == MESSAGE_COUNT)
+        await MaybeAwaitPublishes(publishTasks, batchSize);
+    }
+
+    // Await any remaining tasks in case message count was not
+    // evenly divisible by batch size.
+    await MaybeAwaitPublishes(publishTasks, 0);
+
+    sw.Stop();
+    Console.WriteLine($"{DateTime.Now} [INFO] published {MESSAGE_COUNT:N0} messages in batch in {sw.ElapsedMilliseconds:N0} ms");
+}
+
+static async Task MaybeAwaitPublishes(List<ValueTask> publishTasks, int batchSize)
+{
+    if (publishTasks.Count >= batchSize)
+    {
+        foreach (ValueTask pt in publishTasks)
         {
-            foreach (ValueTask pt in publishTasks)
+            try
             {
-                try
-                {
-                    await pt;
-                }
-                catch (Exception ex)
-                {
-                    Console.Error.WriteLine($"{DateTime.Now} [ERROR] saw nack or return, ex: '{ex}'");
-                }
+                await pt;
+            }
+            catch (Exception ex)
+            {
+                Console.Error.WriteLine($"{DateTime.Now} [ERROR] saw nack or return, ex: '{ex}'");
             }
-            publishTasks.Clear();
         }
+        publishTasks.Clear();
     }
-
-    sw.Stop();
-    Console.WriteLine($"{DateTime.Now} [INFO] published {MESSAGE_COUNT:N0} messages in batch in {sw.ElapsedMilliseconds:N0} ms");
 }
 
 async Task HandlePublishConfirmsAsynchronously()