Inline in_batches false-positive on Migration/BatchInBatches

[barak-neeman]

Model.where(field: nil).in_batches.update_all(field: false)

Gets flagged by the Migration/BatchInBatches cop, and auto-corrected to:

Model.where(field: nil).in_batches.in_batches do |relation|
  relation.update_all(field: false)
end

Please update the Migration/BatchInBatches cop to allow for the above inline usage of in_batches, as the correction is unnecessary and produces code with two consecutive in_batches calls.

[r7kamura]

Thank you for your report! I completely forgot about that when I implemented it.

Maybe if we improve in these lines, I think it will work also in inline calls:

rubocop-migration/lib/rubocop/cop/migration/batch_in_batches.rb

Lines 88 to 91 in 14c09ee

	def wrong?(node)
	batch_processing?(node) &&
	!within_in_batches?(node)
	end

[r7kamura]

Maybe we should also use the inline style for autocorrection?

# bad
User.update_all(some_column: 'some value')

# good
User.in_batches.update_all(some_column: 'some value')

[r7kamura]

Added support for inline in_batches at:

• Fix inline in_batches false-positive on Migration/BatchInBatches #16

and also changed its autocorrection result to prefer the inline style over the block style at:

• Prefer inline in_batches on Migration/BatchInBatches autocorrection #17

[r7kamura]

Just published v0.5.0:

• https://github.com/r7kamura/rubocop-migration/releases/tag/v0.5.0
• https://rubygems.org/gems/rubocop-migration/versions/0.5.0

It was a good opportunity to improve Migration/BatchInBatches. Thanks again!

[barak-neeman]

Update works for all my test cases, and amazingly fast too!
Thank you very much!!