Skip to content

Commit 3753d67

Browse files
committed
fix: logo-alt broken when logo-href provided
Fixes #10251
1 parent 7185c4e commit 3753d67

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

news/changelog-1.6.md

+4
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@ All changes included in 1.6:
1717
- ([#10217](https://github.com/quarto-dev/quarto-cli/issues/10217)): Explicitly compute units for image dimensions in `typst` format when they're not given.
1818
- ([#10212](https://github.com/quarto-dev/quarto-cli/issues/10212)): Moves Pandoc variables to the function declaration for the default template.
1919

20+
## Website
21+
22+
- ([#10251](https://github.com/quarto-dev/quarto-cli/issues/10251)): EJS template for website now uses proper object to get alt text for logo.
23+
2024
## Engines
2125

2226
### `julia`

src/resources/projects/website/templates/sidebar.ejs

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
<div class="pt-lg-2 mt-2 <%= alignCss %> sidebar-header<%= sidebar.logo && sidebar.title ? ' sidebar-header-stacked' : '' %>">
3737
<% if (sidebar.logo) { %>
3838
<a href="<%- sidebar['logo-href'] || '/index.html' %>" class="sidebar-logo-link">
39-
<img src="<%- sidebar.logo %>" alt="<%- navbar['logo-alt'] || '' %>" class="sidebar-logo py-0 d-lg-inline d-none"/>
39+
<img src="<%- sidebar.logo %>" alt="<%- sidebar['logo-alt'] || '' %>" class="sidebar-logo py-0 d-lg-inline d-none"/>
4040
</a>
4141
<% } %>
4242
<% if (needsTools && toolsLocation === "logo") { %>
@@ -92,4 +92,4 @@
9292
<% } %>
9393

9494
</nav>
95-
<div id="quarto-sidebar-glass" class="quarto-sidebar-collapse-item" data-bs-toggle="collapse" data-bs-target=".quarto-sidebar-collapse-item" ></div>
95+
<div id="quarto-sidebar-glass" class="quarto-sidebar-collapse-item" data-bs-toggle="collapse" data-bs-target=".quarto-sidebar-collapse-item" ></div>

0 commit comments

Comments
 (0)