-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (configurable) merging for user defined files for uber-jar creation #46129
Comments
/cc @radcortez (config) |
Not a bad idea. JavaMoney would probably need a custom Extension to make this work in combining files now. Did you also look into this Quarkus JavaMoney extension: https://github.com/quarkiverse/quarkus-moneta |
@Dudeplayz if you open a ticket at Quarkus Moneta this is a really easy fix. @BuildStep(onlyIf = IsNormal.class)
void uberJarFiles(BuildProducer<UberJarMergedResourceBuildItem> uberJarMergedProducer) {
uberJarMergedProducer.produce(new UberJarMergedResourceBuildItem("javamoney.properties"));
} |
cc @andlinger |
+1 for including it in the extension.
…On Thu, Feb 6, 2025 at 7:02 PM Melloware ***@***.***> wrote:
cc @andlinger <https://github.com/andlinger>
—
Reply to this email directly, view it on GitHub
<#46129 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJYOBK2KOS3JOH4YFMVJ3D2OOPTTAVCNFSM6AAAAABWUBOJSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBQGYYTGOBXHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
PR submitted: quarkiverse/quarkus-moneta#82 |
Thanks! But maybe it still would be a good addition to have some config property to simply allow it for other resources, without the need to create an own extension? |
Yep its still assigned to the Quarkus but i thought it was worth fixing in the extension for others! |
Description
I am using https://github.com/JavaMoney/jsr354-ri which defines multiple javamoney.properties. Before I used the maven-shade-plugin with
which combined these before.
Now only one is picked, which blocks the app from starting, because the configuration for the requested ExchangeRateProvider can't be found.
Implementation ideas
UberJarMergedResourceBuildItem could be used for it. There is a config property to specify the ignored resources
quarkus.package.jar.user-configured-ignored-entries
, similar there could bequarkus.package.jar.user-configured-merged-entries
.The text was updated successfully, but these errors were encountered: