Skip to content

Commit 35820f3

Browse files
PaulZhang12facebook-github-bot
authored andcommitted
Dynamic Embeddings CI compatible with linux upgrade (#2565)
Summary: Pull Request resolved: #2565 Update Dynamic Embeddings CI to CUDA 12.1, 12.4 and upgrade to manylinux 2. Reviewed By: kausv Differential Revision: D66100945 fbshipit-source-id: 8f26efcc50ef9a02319f3faa346f48fbe7336c6e
1 parent eb14692 commit 35820f3

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

.github/workflows/build_dynamic_embedding_wheels.yml

+4-3
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ jobs:
2020
fail-fast: false
2121
matrix:
2222
os: [ ubuntu-latest ]
23-
pyver: [ cp39, cp310 ]
24-
cuver: [ "11.8" ]
23+
pyver: [ cp39, cp310, cp311, cp312 ]
24+
cuver: [ "12.1", "12.4"]
2525

2626
steps:
2727
-
@@ -41,13 +41,14 @@ jobs:
4141
with:
4242
submodules: recursive
4343

44-
- uses: pypa/cibuildwheel@v2.19.2
44+
- uses: pypa/cibuildwheel@v2.20.0
4545
with:
4646
package-dir: contrib/dynamic_embedding
4747
env:
4848
CIBW_BEFORE_BUILD: "env CUDA_VERSION=${{ matrix.cuver }} contrib/dynamic_embedding/tools/before_linux_build.sh"
4949
CIBW_BUILD: "${{ matrix.pyver }}-manylinux_x86_64"
5050
CIBW_REPAIR_WHEEL_COMMAND: "env CUDA_VERSION=${{ matrix.cuver }} contrib/dynamic_embedding/tools/repair_wheel.sh {wheel} {dest_dir}"
51+
CIBW_MANYLINUX_X86_64_IMAGE: "manylinux_2_28"
5152

5253
- name: Verify clean directory
5354
run: git diff --exit-code

contrib/dynamic_embedding/tools/before_linux_build.sh

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ CUDA_VERSION="${CUDA_VERSION:-11.8}"
1414
CUDA_MAJOR_VERSION=$(echo "${CUDA_VERSION}" | tr '.' ' ' | awk '{print $1}')
1515
CUDA_MINOR_VERSION=$(echo "${CUDA_VERSION}" | tr '.' ' ' | awk '{print $2}')
1616

17+
yum install -y yum-utils
1718
yum-config-manager --add-repo https://developer.download.nvidia.com/compute/cuda/repos/$distro/$arch/cuda-$distro.repo
1819
yum install -y \
1920
cuda-toolkit-"${CUDA_MAJOR_VERSION}"-"${CUDA_MINOR_VERSION}" \

contrib/dynamic_embedding/tools/build_wheels.sh

+2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ export CIBW_BEFORE_BUILD="tools/before_linux_build.sh"
66
# all kinds of CPython.
77
export CIBW_BUILD=${CIBW_BUILD:-"cp39-manylinux_x86_64"}
88

9+
export CIBW_MANYLINUX_X86_64_IMAGE=${CIBW_MANYLINUX_X86_64_IMAGE:-"manylinux_2_28"}
10+
911
# Do not auditwheels since tde uses torch's shared libraries.
1012
export CIBW_REPAIR_WHEEL_COMMAND="tools/repair_wheel.sh {wheel} {dest_dir}"
1113

0 commit comments

Comments
 (0)