Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate test cases which are timing sensitive #130363

Open
rossburton opened this issue Feb 20, 2025 · 1 comment
Open

Annotate test cases which are timing sensitive #130363

rossburton opened this issue Feb 20, 2025 · 1 comment
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@rossburton
Copy link
Contributor

rossburton commented Feb 20, 2025

Feature or enhancement

Proposal:

Many tests in the cpython test suite are sensitive to timing and assume an entirely unloaded system. For example, the TimerfdTests check for 1ms accuracy in expected durations. Some people (eg people building and testing python) may be running the test suite on build machines which are potentially heavily loaded so this sort of expectation isn't feasible.

It seems like a good solution to this would be to annotate the tests which are timing sensitive in some way, so they can be skipped easily.

For reference, we're manually patching python to skip tests which are failing under load but we're now having to rebase these patches on upgrades:

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

@rossburton rossburton added the type-feature A feature request or enhancement label Feb 20, 2025
@tomasr8 tomasr8 added the tests Tests in the Lib/test dir label Feb 20, 2025
@encukou
Copy link
Member

encukou commented Feb 21, 2025

Sounds like it could be a new resource, see python -m test --help and test.support.requires.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants