Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs are failing b/c altair is not py313 ready yet #2016

Closed
ocefpaf opened this issue Oct 22, 2024 · 6 comments · Fixed by #2017
Closed

Docs are failing b/c altair is not py313 ready yet #2016

ocefpaf opened this issue Oct 22, 2024 · 6 comments · Fixed by #2017

Comments

@ocefpaf
Copy link
Member

ocefpaf commented Oct 22, 2024

xref.: vega/altair#3620

@Conengmo
Copy link
Member

Weird that the workflow didn't fail on the py313 PR #2013...

@Conengmo
Copy link
Member

I'll build the latest release docs manually, since we now passed that window.

@Conengmo
Copy link
Member

I tried to make a temporary fix #2017

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 23, 2024

Weird that the workflow didn't fail on the py313 PR #2013...

We are pinning to an exact Python in the docs, which is fine, but the "python=3" means that sometimes we can build them with 3.12 if the solver feels like it 😄

@Conengmo
Copy link
Member

ooh okay, so we should actually pin to an exact version there, that's more robust!

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 23, 2024

ooh okay, so we should actually pin to an exact version there, that's more robust!

It should not matter in an ideal world but... Yeah, probably safer b/c we do depend on dozens of libs in our docs and demos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants