From b3622f9e583157327ca37462d896bc04b4999905 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edgar=20Andr=C3=A9s=20Margffoy=20Tuay?= Date: Tue, 25 Mar 2025 12:08:24 -0500 Subject: [PATCH 1/3] Use native aarch64 Ci builders --- .github/workflows/build.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b0077f8..4d7b58d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -38,7 +38,7 @@ jobs: artifact_name: "linux-x86_64" # Linux ARM64 builds (native runners) - - os: ubuntu-latest + - os: ubuntu-24.04-arm arch: aarch64 cibw_pattern: "cp3{10,11,12,13,13t}-manylinux*" artifact_name: "linux-aarch64" @@ -72,11 +72,11 @@ jobs: echo "CIBW_BEFORE_TEST=pip install pytest pytest-run-parallel" >> "$GITHUB_ENV" echo "CIBW_TEST_COMMAND=pytest --parallel-threads=4 --pyargs numexpr" >> "$GITHUB_ENV" - - name: Set up QEMU - if: matrix.arch == 'aarch64' - uses: docker/setup-qemu-action@v3 - with: - platforms: arm64 + # - name: Set up QEMU + # if: matrix.arch == 'aarch64' + # uses: docker/setup-qemu-action@v3 + # with: + # platforms: arm64 - name: Build wheels uses: pypa/cibuildwheel@v2.23 From 256330f83ba8cc9a49d8ce3fa7f46c01bf0df967 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edgar=20Andr=C3=A9s=20Margffoy=20Tuay?= Date: Tue, 25 Mar 2025 12:21:10 -0500 Subject: [PATCH 2/3] Do not skip tests on aarch64 --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 4d7b58d..1186ee0 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -11,7 +11,7 @@ env: CIBW_BUILD_VERBOSITY: 1 CIBW_TEST_COMMAND: pytest --pyargs numexpr # Testing on aarch64 takes too long, as it is currently emulated on GitHub Actions - CIBW_TEST_SKIP: "*linux*aarch64*" + # CIBW_TEST_SKIP: "*linux*aarch64*" # Building for musllinux and aarch64 takes way too much time. # Moreover, NumPy is not providing musllinux for x86_64 either, so it's not worth it. CIBW_SKIP: "*musllinux*aarch64* *musllinux*x86_64*" From 9c3e9d575c04abb50833c3be38a897e22d68a3f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edgar=20Andr=C3=A9s=20Margffoy=20Tuay?= Date: Tue, 25 Mar 2025 18:07:54 -0500 Subject: [PATCH 3/3] Remove commented sections --- .github/workflows/build.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1186ee0..151efda 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -11,7 +11,6 @@ env: CIBW_BUILD_VERBOSITY: 1 CIBW_TEST_COMMAND: pytest --pyargs numexpr # Testing on aarch64 takes too long, as it is currently emulated on GitHub Actions - # CIBW_TEST_SKIP: "*linux*aarch64*" # Building for musllinux and aarch64 takes way too much time. # Moreover, NumPy is not providing musllinux for x86_64 either, so it's not worth it. CIBW_SKIP: "*musllinux*aarch64* *musllinux*x86_64*" @@ -72,12 +71,6 @@ jobs: echo "CIBW_BEFORE_TEST=pip install pytest pytest-run-parallel" >> "$GITHUB_ENV" echo "CIBW_TEST_COMMAND=pytest --parallel-threads=4 --pyargs numexpr" >> "$GITHUB_ENV" - # - name: Set up QEMU - # if: matrix.arch == 'aarch64' - # uses: docker/setup-qemu-action@v3 - # with: - # platforms: arm64 - - name: Build wheels uses: pypa/cibuildwheel@v2.23