Skip to content

Commit 6274b61

Browse files
committed
MNT: Deprecate python 3.7 and 3.8
`setuptools` has removed some stuff needed to build numpy on old platforms: numpy/numpy#27405 So the musllinux distributions on 3.8 don't build anymore. I tried to enforce setuptools<74 for python < 3.9, but it seems pip doesn't guarantee the order of the dependencies, so `oldest-supported-numpy` gets installed before setuptools is, failing... For simplicity I'm removing support for these versions
1 parent 4a3cd27 commit 6274b61

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

.github/workflows/ci.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
runs-on: ${{ matrix.os }}
88
strategy:
99
matrix:
10-
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
10+
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
1111
architecture: [x86, x64]
1212
os:
1313
[
@@ -68,7 +68,7 @@ jobs:
6868
- name: Build wheels
6969
uses: pypa/[email protected]
7070
env:
71-
CIBW_SKIP: pp* cp36-*
71+
CIBW_SKIP: pp* cp36-* cp37-* cp38-*
7272

7373
- name: Store wheel artifacts
7474
uses: actions/upload-artifact@v4

RELEASE.rst

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ Bottleneck 1.4.1
1313
1414
Enhancements
1515
~~~~~~~~~~~~
16+
- Deprecate Python 3.7 and 3.8
1617
- Add python 3.13 build
1718

1819
Bottleneck 1.4.0

pyproject.toml

+3-5
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
[build-system]
22
requires = [
3+
# Setuptools has removed support for msvccompiler
4+
# this is needed to build old versions of bottleneck
35
"setuptools",
46
"versioneer",
57
"wheel",
6-
"oldest-supported-numpy ; python_version < '3.9'",
7-
# Setuptools has removed support for msvccompiler
8-
# this is needed to build old versions of bottleneck
9-
"setuptools<74 ; python_version < '3.9'",
108
# Comments on numpy build requirement range:
119
#
1210
# 1. >=2.0.x is the numpy requirement for wheel builds for distribution
@@ -17,5 +15,5 @@ requires = [
1715
# and disabling build isolation.
1816
# 3. The <2.3 upper bound is for matching the numpy deprecation policy,
1917
# it should not be loosened
20-
"numpy>=2.0.0rc1,<2.3 ; python_version >= '3.9'",
18+
"numpy>=2,<2.3"
2119
]

0 commit comments

Comments
 (0)