-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup CI testing of Website Build #36
Comments
I am interested |
that would be awesome @Athene-ai you are welcome to work on this and submit a PR to this repo if this is something that you'd like to work on. And if you need more information please say the word! |
@lwasser thanks and for sure I will take a look at this repo ;-) |
Thank you @Athene-ai! In case it helps, this is what usrse.github.io uses to build: I also saw that |
And this is what the US-RSE site uses for link checking in actions 👇 - name: URLs-checker
# Will be updated to 0.0.26
uses: urlstechie/[email protected]
with:
# A comma-separated list of file types to cover in the URL checks
file_types: .md,.py,.yml
# Choose whether to include file with no URLs in the prints.
print_all: false
# More verbose summary at the end of a run
verbose: true
# How many times to retry a failed request (defaults to 1)
retry_count: 3
# Google Forms is having enormous timeouts
timeout: 10
# Exclude these patterns from the checker
exclude_patterns: supercomputing.org,https://pace.gatech.edu,https://www.linkedin.com,jobs.colorado.edu,zoom.us,danielskatz.org,usrse.github.io.wiki.git,ornl.gov,jobs.bnl.gov,https://www.rd-alliance.org/,https://uwhires.admin.washington.edu/
# Exclude these files from the checker
exclude_files: README.md,SocialNetworks.yml,map.yml,_config.yml,tests/test_,.github/workflows,_posts/newsletters/ |
heya @NickleDave i actually setup an action like this for earthdatascience.org - please check out the original issue for an example. UPDATE SOMETHING IS NOT RIGHT with THAT LINK>.. let me find it. |
Circle CI is for previews. If you don’t plan on having many builds, Netlify (free tier) is amazing, but the free tier is too small for a very busy site. |
ok i fixed the link. that is really odd!! |
👋 @vsoch !!! we are definitely interested in netlify - also to get out of the annoying safe mode limitations here |
That version of urlchecker is very old. https://github.com/urlstechie/urlchecker-action/releases/tag/0.0.33 For transparency, I maintain this library. |
Ah whoops I should have asked for clarification about why the link was not actions before dumping in a bunch of other stuff. @Athene-ai feel free to ignore me and work from the Actions that @lwasser linked to now that it's fixed: sorry 😁 😬 |
@NickleDave absolutely do not worry about 😉 |
i second @Athene-ai ... maybe they have a better idea as to how to build our workflow :) thank you @NickleDave for the input!! and thank y'all for the suggestions and guidance and for being here! y'all rock! |
Ok this has been setup already so closing !! |
Our website build should be tested each time there is a new PR. This can be done with GitHub Actions
Here is an example of how testing happens on another site that i setup
It will be easy to setup the same thing here. this is in reference to 2 recent PR's (THANK YOU AGAIN FOR THESE) from folks catching broken links @xuanxu @NickleDave
Tasks:
The build should run on all branches and PR's so that we don't merge pr's that break the site.
The text was updated successfully, but these errors were encountered: