Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create safe constructors for Leafs #15

Open
jvliwanag opened this issue Oct 8, 2020 · 1 comment
Open

Create safe constructors for Leafs #15

jvliwanag opened this issue Oct 8, 2020 · 1 comment

Comments

@jvliwanag
Copy link
Member

We probably should hide the newtype constructors for the types in Leafs - or at least offer safe alternatives to instantiate those types.

For instance, right now, it's possible to create a ProperName "notAProperName" which shouldn't be the case. (Since ProperNames should start with a capital letter).
@srghma
Copy link
Collaborator

srghma commented Oct 9, 2020

right, true for constructors

we should offer safe and unsafe constructors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jvliwanag @srghma