Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad naming convention for providers #284

Open
logicminds opened this issue Jul 16, 2018 · 3 comments
Open

bad naming convention for providers #284

logicminds opened this issue Jul 16, 2018 · 3 comments

Comments

@logicminds
Copy link
Contributor

logicminds commented Jul 16, 2018

Should fix this before it gets out of hand. Why the triple stacked classes?

module Vmpooler
  class PoolManager
    class Provider
      class VSphere

      end
    end
  end
end

I don't understand why someone coded this way. We can fix by using module namespaces instead. However since there is also a pool manager class we also just need to remove that bit too.

Example:

module Vmpooler
    module Provider
      class VSphere

      end
    end
end
@glennsarti
Copy link
Contributor

glennsarti commented Jul 23, 2018

Whoops...my bad...yes they should be modules. Probably came from me 1) cargo culting from the old-old code 2) me being naive

@yachub
Copy link

yachub commented Apr 20, 2023

We're migrating issue management to Jira, so tracking this has been moved to https://puppet.atlassian.net/browse/POOLER-217

@yachub yachub closed this as completed Apr 20, 2023
@yachub
Copy link

yachub commented Jul 11, 2023

We're migrating issue management to Jira, so tracking this has been moved to https://puppet.atlassian.net/browse/POOLER-217

Apologies for the noise, we went full circle here and decided to move from Jira Cloud to GitHub Projects instead.

@yachub yachub reopened this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants