-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPU Arch detection appears fragile and doesn't take into account Vmware EVC #201
Comments
It's true. It probably makes more sense to detect whether EVC is configured. When it is not, then perhaps falling back to determining compatibility based on ESXi compatibility version. |
The biggest arch problem tends to be AMD vs Intel as opposed to, say, v3 or V4 of an Intel processor. It would be nice if vSphere offered an API to say "Can I vMotion from Host1 to Host2?" but alas ... |
We're migrating issue management to Jira, so tracking this has been moved to https://puppet.atlassian.net/browse/POOLER-220 |
Apologies for the noise, we went full circle here and decided to move from Jira Cloud to GitHub Projects instead. |
The code in https://github.com/puppetlabs/vmpooler/blob/master/lib/vmpooler/vsphere_helper.rb#L216-L221 seems very fragile by only using the 5th element in a CPU description and doesn't seem to take into account VMWare EVC (https://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=1003212) which reduces the vCPU features presented to the guests.
This should perhaps use a better method of arch detection
The text was updated successfully, but these errors were encountered: