Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you please support jdk11? #32

Open
gitzhan opened this issue Mar 25, 2024 · 9 comments
Open

Could you please support jdk11? #32

gitzhan opened this issue Mar 25, 2024 · 9 comments

Comments

@gitzhan
Copy link

gitzhan commented Mar 25, 2024

The current artifact supports only jdk17+,Could you please support jdk11?thanks!

@pseudoankit
Copy link
Owner

Library uses jdk 11 only, are you facing any issues?
also the demo app uses jdk 8 and it works fine with the lib, what issue are facing while integrating?

@gitzhan
Copy link
Author

gitzhan commented Mar 26, 2024

I confirmed it again.
1、I'm just generating a new pure project from https://kmp.jetbrains.com/ (My project environment is jdk11)
2、Then,just add this dependency
3、Run the lib's demo in the main application function
4、after this,I received an error
some screenshot show below:
image
image

@pseudoankit
Copy link
Owner

let me check this

@pseudoankit
Copy link
Owner

pseudoankit commented Mar 27, 2024

Did complete same steps able to run in desktop too
1 issue I faced with 1.8.0 is iosArm64 not present, can you try using version 1.7.1 and see if you are facing the issue meanwhile I am checking this issue the iosArm64 issue

Also can you please try to run in ios/android device?

@gitzhan
Copy link
Author

gitzhan commented Apr 2, 2024

sorry for this,my project is just for desktop/jvm.
today,I took the time to download the source code here, and then use my environment to compile,it work well.
My guess is that the project compilation or release scripts here are the reason why jdk11 is not supported

@pseudoankit
Copy link
Owner

pseudoankit commented Apr 3, 2024

yeah release flow uses jdk 17 but the library uses 11 only,
did you tried the latest release 2.0.3, there was 1 issue I was using linux OS for release deployment so ios artifacts were not uploading changed to macOS not sure if this has anything do with your issue but just asking

I already did the complete same steps and I was able to use it desktop too

@pseudoankit
Copy link
Owner

pseudoankit commented Apr 3, 2024

Hey I tried again and it seems to work
Created a KMP project from the template andorid/iOS/desktop/web
added the library deps

Got a error related to WASM I have not supported this, so commented out wasmJs block synced and was able to run
Got another issue that run button for desktop not working so ran the command to launch desktop ./gradlew :composeApp:run

Additionally can you please check your jdk in studio setting AndroidStudio -> Settings -> BuildsTools -> Gradle -> Gradle JDK (mine is to set to JBR 17)

and what is your java version mine is 20.0.1

@gitzhan
Copy link
Author

gitzhan commented Apr 11, 2024

My Gradle JVM is the same as the project SDK, which is JDK11(11.0.12).
then I tried version 2.0.3 and it still told me that the project needed jdk17+ to work.

@pseudoankit
Copy link
Owner

@gitzhan did you tried with version I shared in last message
still facing the issue, then can you please push the code and share me the repo will have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants