Treat Bits as OctetString

sebastien-coavoux · sebastien-coavoux · commit eb1a0e3fc2dd · 2023-03-30T22:53:52.000-04:00
diff --git a/collector/collector.go b/collector/collector.go
@@ -621,7 +621,7 @@ func pduValueAsString(pdu *gosnmp.SnmpPDU, typ string) string {
 		// DisplayString.
 		return pdu.Value.(string)
 	case []byte:
-		if typ == "" {
+		if typ == "" || typ == "Bits" {
 			typ = "OctetString"
 		}
 		// Reuse the OID index parsing code.
diff --git a/collector/collector_test.go b/collector/collector_test.go
@@ -701,6 +701,11 @@ func TestPduValueAsString(t *testing.T) {
 			typ:    "InetAddressIPv6",
 			result: "0102:0304:0506:0708:090A:0B0C:0D0E:0F10",
 		},
+		{
+			pdu:    &gosnmp.SnmpPDU{Value: []byte{2, 0}},
+			typ:    "Bits",
+			result: "0x0200",
+		},
 		{
 			pdu:    &gosnmp.SnmpPDU{Value: nil},
 			result: "",

Original file line number	Diff line number	Diff line change
`@@ -621,7 +621,7 @@ func pduValueAsString(pdu *gosnmp.SnmpPDU, typ string) string {`
`621`	`621`	`// DisplayString.`
`622`	`622`	`return pdu.Value.(string)`
`623`	`623`	`case []byte:`
`624`		`- if typ == "" {`
	`624`	`+ if typ == "" \|\| typ == "Bits" {`
`625`	`625`	`typ = "OctetString"`
`626`	`626`	`}`
`627`	`627`	`// Reuse the OID index parsing code.`