Treat Bits as OctetString (#870)

sebastien-coavoux · web-flow · commit 9999e5901866 · 2023-05-02T10:42:53.000+02:00
Signed-off-by: Sébastien Coavoux &lt;sebastien.coavoux@azoplee.com&gt;
diff --git a/collector/collector.go b/collector/collector.go
@@ -725,7 +725,7 @@ func pduValueAsString(pdu *gosnmp.SnmpPDU, typ string) string {
 		// DisplayString.
 		return pdu.Value.(string)
 	case []byte:
-		if typ == "" {
+		if typ == "" || typ == "Bits" {
 			typ = "OctetString"
 		}
 		// Reuse the OID index parsing code.
diff --git a/collector/collector_test.go b/collector/collector_test.go
@@ -701,6 +701,11 @@ func TestPduValueAsString(t *testing.T) {
 			typ:    "InetAddressIPv6",
 			result: "0102:0304:0506:0708:090A:0B0C:0D0E:0F10",
 		},
+		{
+			pdu:    &gosnmp.SnmpPDU{Value: []byte{2, 0}},
+			typ:    "Bits",
+			result: "0x0200",
+		},
 		{
 			pdu:    &gosnmp.SnmpPDU{Value: nil},
 			result: "",

Original file line number	Diff line number	Diff line change
`@@ -725,7 +725,7 @@ func pduValueAsString(pdu *gosnmp.SnmpPDU, typ string) string {`
`725`	`725`	`// DisplayString.`
`726`	`726`	`return pdu.Value.(string)`
`727`	`727`	`case []byte:`
`728`		`- if typ == "" {`
	`728`	`+ if typ == "" \|\| typ == "Bits" {`
`729`	`729`	`typ = "OctetString"`
`730`	`730`	`}`
`731`	`731`	`// Reuse the OID index parsing code.`