Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_previous_next_doc.html.erb deprecation in 7.x should use updated component name #3313

Open
sandbergja opened this issue Sep 3, 2024 · 0 comments

Comments

@sandbergja
Copy link
Contributor

Right now on the release-7.x branch, _previous_next_doc.html.erb includes the following deprecation notice:

The partial _previous_next_doc.html.erb will be removed in 8.0. Render Blacklight::SearchContextComponent instead.

This is outdated advice, since Blacklight::SearchContextComponent was renamed to Blacklight::SearchContext::ServerItemPaginationComponent in commit 9bd3ecb.

We should update the deprecation message. It would also be nice to backport that component to release-7.x without removing SearchContextComponent, so that Blacklight 7 sites can start using ServerItemPaginationComponent rather than SearchContextComponent.

maxkadel added a commit to maxkadel/blacklight that referenced this issue Oct 28, 2024
maxkadel added a commit to maxkadel/blacklight that referenced this issue Oct 28, 2024
sandbergja added a commit that referenced this issue Nov 5, 2024
…BL8 upgrade path (#3421)

* Copy SearchContextComponent to ServerItemPaginationComponent to ease BL8 upgrade path

Closes #3313

* Keep using old component for backwards compatibility

- Test components

Co-authored-by: Jane Sandberg <[email protected]>

* Have copied component inherit from main component, just with updated signature

---------

Co-authored-by: Jane Sandberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant