Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 9615f65

Browse files
committedNov 7, 2023
refactor: generic resources
1 parent 280e750 commit 9615f65

File tree

4 files changed

+329
-379
lines changed

4 files changed

+329
-379
lines changed
 

‎pkg/controller/queuejob/queuejob_controller_ex.go

+3-7
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ import (
5353
apierrors "k8s.io/apimachinery/pkg/api/errors"
5454
"k8s.io/apimachinery/pkg/api/meta"
5555
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
56-
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
5756
"k8s.io/apimachinery/pkg/labels"
5857
"k8s.io/apimachinery/pkg/util/wait"
5958
"k8s.io/client-go/kubernetes"
@@ -583,13 +582,10 @@ func (qjm *XController) getAppWrapperCompletionStatus(caw *arbv1.AppWrapper) arb
583582
for i, genericItem := range caw.Spec.AggrResources.GenericItems {
584583
if len(genericItem.CompletionStatus) > 0 {
585584
objectName := genericItem.GenericTemplate
586-
var unstruct unstructured.Unstructured
587-
unstruct.Object = make(map[string]interface{})
588-
var blob interface{}
589-
if err := jsons.Unmarshal(objectName.Raw, &blob); err != nil {
590-
klog.Errorf("[getAppWrapperCompletionStatus] Error unmarshalling, err=%#v", err)
585+
unstruct, err := genericresource.UnmarshalToUnstructured(objectName.Raw)
586+
if err != nil {
587+
klog.Errorf("[getAppWrapperCompletionStatus] Error: %v", err)
591588
}
592-
unstruct.Object = blob.(map[string]interface{}) // set object to the content of the blob after Unmarshalling
593589
name := ""
594590
if md, ok := unstruct.Object["metadata"]; ok {
595591
metadata := md.(map[string]interface{})

0 commit comments

Comments
 (0)
Please sign in to comment.