Merge pull request #48 from project-codeflare/fix-typescript-errors

typescript errors fix

Author: mamy-CS

backend/src/routes/api/appwrappers/appwrapper-utils.ts

@@ -1,5 +1,4 @@
 const { spawn } = require('child_process');
-const http = require('http');
 
 class AllAppwrappers {
   async get() {
@@ -29,7 +28,7 @@ class AllAppwrappers {
       //Identify message in last status condition, if state is other than 'Running'
       const conditionsArr: any[] = jsonData.status.conditions;
       const lastCondition = conditionsArr[conditionsArr.length - 1];
-      let message: string = '';
+      let message = '';
 
       message = message + lastCondition.type;
       message = message + '. Reason: ' + lastCondition.reason;
@@ -40,7 +39,7 @@ class AllAppwrappers {
       jsonData.status.constructedMessage = message;
 
       // create formatted age
-      let timestr: string = '';
+      let timestr = '';
       if (jsonData.metadata.creationTimestamp) {
         const dtCreation = new Date(jsonData.metadata.creationTimestamp);
         const delta = dtNow.getTime() - dtCreation.getTime();
@@ -67,9 +66,9 @@ class AllAppwrappers {
       jsonData.metadata.calculatedTimeSpent = timestr;
 
       // Identify status and add to counts
-      let numRequeuings: number = 0;
+      let numRequeuings = 0;
       const state: string = jsonData.status.state.trim();
-      let rephrasedState: string = '';
+      let rephrasedState = '';
       if (state === '') {
         rephrasedState = 'Submitted';
         statusCounts.Other = statusCounts.Other + 1;
@@ -170,7 +169,7 @@ class AllAppwrappers {
 
   pullJobs(): Promise<string> {
     return new Promise((resolve, reject) => {
-      let jsonString: string = '';
+      let jsonString = '';
       const child = spawn('sh', ['./src/routes/api/appwrappers/appwrapper_puller.sh'], {
         stdio: 'pipe',
         buffer: true,

backend/src/routes/api/appwrappers/index.ts

@@ -1,6 +1,5 @@
 import { secureRoute } from '../../../utils/route-security';
-import { KubeFastifyInstance, OauthFastifyRequest } from '../../../types';
-import { FastifyRequest, FastifyReply } from 'fastify';
+import { KubeFastifyInstance } from '../../../types';
 import { AllAppwrappers } from './appwrapper-utils';
 
 module.exports = module.exports = async (fastify: KubeFastifyInstance) => {

backend/src/routes/api/dev-impersonate/index.ts

@@ -6,7 +6,7 @@ import { KubeFastifyInstance } from '../../../types';
 import {
   DEV_IMPERSONATE_PASSWORD,
   DEV_IMPERSONATE_USER,
-  DEV_IMPERSONATE_TOKEN,  // Temporary workaround: get impersonate to work through a token, because of hostname resolve the problem and IBM not using OAuth proxy
+  DEV_IMPERSONATE_TOKEN, // Temporary workaround: get impersonate to work through a token, because of hostname resolve the problem and IBM not using OAuth proxy
 } from '../../../utils/constants';
 import { createCustomError } from '../../../utils/requestUtils';
 import { devRoute } from '../../../utils/route-security';

backend/src/routes/api/mcad-prometheus/index.ts

@@ -1,6 +1,5 @@
 import { secureRoute } from '../../../utils/route-security';
 import { KubeFastifyInstance, OauthFastifyRequest } from '../../../types';
-import { FastifyRequest, FastifyReply } from 'fastify';
 import { metricsData } from './metricsData';
 
 module.exports = module.exports = async (fastify: KubeFastifyInstance) => {

backend/src/routes/api/mcad-prometheus/metricsData.ts

@@ -9,8 +9,8 @@ const fetchPrometheusData = async (host: string, query: string, axiosInstance: A
   });
 
   const url = `https://${host}/api/v1/query?${params.toString()}`;
-  console.log("FETCHING RPOMETJFDKS URL: ", url)
-  return axios//Instance
+  console.log('FETCHING RPOMETJFDKS URL: ', url)
+  return axios //Instance
     .post(url)
     .then((res) => {
       return res.data.data.result;
@@ -66,7 +66,7 @@ const getMetricRange = async (
     step,
     axiosInstance,
   );
-  console.log("fetched range data...: ", fetchedData)
+  console.log('fetched range data...: ', fetchedData)
   return fetchedData;
 };
 

backend/src/routes/api/metrics-data/index.ts

@@ -1,6 +1,5 @@
 import { secureRoute } from '../../../utils/route-security';
 import { KubeFastifyInstance, OauthFastifyRequest } from '../../../types';
-import { FastifyRequest, FastifyReply } from 'fastify';
 import { metricsData } from './metricsData';
 
 module.exports = module.exports = async (fastify: KubeFastifyInstance) => {