Skip to content

Commit 260a7cd

Browse files
authored
Update pull_request.yml
1 parent df36fd0 commit 260a7cd

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

.github/workflows/pull_request.yml

+4-9
Original file line numberDiff line numberDiff line change
@@ -52,26 +52,21 @@ jobs:
5252
- name: Setup Ant
5353
uses: cedx/setup-ant@v3
5454
- name: Install Certificates for Code Signing
55-
if: ${{ matrix.os_prefix == 'macos' }}
55+
env:
56+
cert_secret: ${{ secrets.CERTIFICATES_P12 }}
57+
if: ${{ matrix.os_prefix == 'macos' && secrets.CERTIFICATES_P12 != '' }}
5658
uses: apple-actions/import-codesign-certs@v3
5759
with:
5860
p12-file-base64: ${{ secrets.CERTIFICATES_P12 }}
5961
p12-password: ${{ secrets.CERTIFICATES_P12_PASSWORD }}
6062
- name: Build Release
6163
run: ant -noinput -buildfile build/build.xml ${{ matrix.os_prefix }}-dist -Dversion="${{ github.sha }}"
6264
env:
63-
PROCESSING_APP_SIGNING: true
65+
PROCESSING_APP_SIGNING: secrets.CERTIFICATES_P12 != ''
6466
- name: Add artifact
6567
uses: actions/upload-artifact@v3
6668
id: upload
6769
with:
6870
name: processing-${{github.sha}}${{ matrix.os_prefix }}-${{ matrix.arch }}
6971
path: ./build/${{ matrix.os_prefix }}/processing-${{github.sha}}-${{ matrix.os_prefix}}-*
7072
retention-days: 5
71-
# TODO: Merge into one comment and fix the link
72-
# - uses: mshick/add-pr-comment@v2
73-
# with:
74-
# message-id: "build-artifact ${{ matrix.os_prefix }} ${{ matrix.arch }}"
75-
# message: |
76-
# Build artifacts for ${{ matrix.os_prefix }} (${{ matrix.arch }}) have been created.
77-
# Download the artifacts [here](${{ steps.upload.outputs.artifact-id }}).

0 commit comments

Comments
 (0)