Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ShortCut Key 'Ctrl/Cmd+Alt+f' for newFolder #3379

Closed

Conversation

Jatin24062005
Copy link
Contributor

@Jatin24062005 Jatin24062005 commented Mar 8, 2025

Changes:

p5.js.Web.Editor.-.Brave.2025-03-08.18-14-42.mp4

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim
Copy link
Collaborator

raclim commented Mar 10, 2025

Thanks for taking a look into this!

Although the implementation here is overall correct, I'm seeing conflicting commands with "Replace Text Match". I'm currently using a Mac, so the discrepancy between this and your video might be due to different operating systems that we're using.

Screenshot 2025-03-10 at 10 02 53 AM Screenshot 2025-03-10 at 10 02 24 AM

Since the letter "F" is used a number of times for different commands ("Tidy", "Find Text", "Replace Text Match"), I personally feel that we might want to hold off on it for "New Folder". I posted a comment to the linked issue that I feel like this might need some discussion first on what the command key should be before implementing it.

I'm going to close this for now since I feel like this issue isn't ready for development on it yet, but feel free to share thoughts on what you feel like the best shortcut keys might be within the issue! I think once that's agreed upon, we can go ahead with developing it.

@raclim raclim closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Shortcut for Creating New Folder
2 participants