Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pino v7 upgrade #171

Closed
rethab opened this issue Nov 9, 2021 · 7 comments · Fixed by #311
Closed

pino v7 upgrade #171

rethab opened this issue Nov 9, 2021 · 7 comments · Fixed by #311

Comments

@rethab
Copy link

rethab commented Nov 9, 2021

hey 👋 , pino v7 has been released. are there any plans to upgrade this library to use that new version? if you don't have time, would you be open to a PR?

@gr2m
Copy link
Contributor

gr2m commented Nov 9, 2021

Yes, we would love to update. I looked into it but it was much more involved and I couldn't figure it out in the available time.

Any help with the upgrade would be greatly appreciated

@jetersen
Copy link

This is currently blocking as this is not ESM ready.

@jetersen
Copy link

I would like to see if I cannot tackle this one 😅

@gr2m
Copy link
Contributor

gr2m commented Jan 19, 2022

Awesome, thanks!

@jetersen
Copy link

Only thing left is the tests and I am somewhat stuck on them. Not sure how to properly adapt them.

@dgellow
Copy link

dgellow commented Oct 4, 2023

Any plan to upgrade to v8?

@gr2m
Copy link
Contributor

gr2m commented Oct 4, 2023

pull requests welcome. We are in the process o updating probot/probot to its latest dependencies, which will also drop support for Node < 18. We should be fine with upgrading pino all the way to v8, but we need to go to v7 first, make tests pass, then upgrade to v8

This was linked to pull requests Jan 28, 2025
@wolfy1339 wolfy1339 removed a link to a pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants