Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeView: Add aria-label to TreeView subtree #5174

Merged
merged 6 commits into from
Jan 28, 2025
Merged

TreeView: Add aria-label to TreeView subtree #5174

merged 6 commits into from
Jan 28, 2025

Conversation

TylerJDev
Copy link
Contributor

@TylerJDev TylerJDev commented Oct 24, 2024 •
edited
Loading

Closes #5035

Adds aria-label prop to TreeView.Subtree.

Changelog

New

  • Adds prop aria-label to TreeView.Subtree

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: eb3307c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 24, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5174 October 24, 2024 22:42 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.47 KB (+0.03% 🔺)
packages/react/dist/browser.umd.js 104.8 KB (-0.04% 🔽)

@TylerJDev TylerJDev mentioned this pull request Oct 24, 2024
Closed
@TylerJDev TylerJDev marked this pull request as ready for review October 24, 2024 23:13
@TylerJDev TylerJDev requested a review from a team as a code owner October 24, 2024 23:13
@TylerJDev TylerJDev requested a review from mperrotti October 24, 2024 23:13
@github-actions github-actions bot temporarily deployed to storybook-preview-5174 October 24, 2024 23:14 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5174 December 11, 2024 20:38 Inactive
mik3lartzyx351

This comment was marked as spam.

Sign in to view

@github-actions github-actions bot temporarily deployed to storybook-preview-5174 January 28, 2025 17:15 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5174 January 28, 2025 17:50 Inactive
@hussam-i-am hussam-i-am added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit cf80bf2 Jan 28, 2025
44 checks passed
@hussam-i-am hussam-i-am deleted the tylerjdev/add-label-to-subtree branch January 28, 2025 22:23
@primer primer bot mentioned this pull request Jan 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mik3lartzyx351 mik3lartzyx351 mik3lartzyx351 left review comments

@joshblack joshblack joshblack approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TreeView] Add an explicit aria-label to SubTree ul elements for Safari VoiceOver support
4 participants
@TylerJDev @joshblack @mik3lartzyx351 @hussam-i-am