Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: Reorder feature is broken #7341

Open
1 of 4 tasks
liuchunlei-jpg opened this issue Feb 27, 2025 · 8 comments
Open
1 of 4 tasks

DataTable: Reorder feature is broken #7341

liuchunlei-jpg opened this issue Feb 27, 2025 · 8 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@liuchunlei-jpg
Copy link

Describe the bug

DataTable Reorder feature on the official website is broken
https://primevue.org/datatable/#reorder

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/qp6p6ewi?file=src%2FApp.vue

Environment

Chrome on macos

Vue version

3.5.13

PrimeVue version

4.3.1

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

Just visit official site

Expected behavior

Just works

@liuchunlei-jpg liuchunlei-jpg added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 27, 2025
@liuchunlei-jpg liuchunlei-jpg changed the title DataTable: Reorder feature is broken https://primevue.org/datatable/#reorder DataTable: Reorder feature is broken Feb 27, 2025
@prabinsh
Copy link

I didn't have any issue with the reorder. Can you please explain behavior you are observing?

@AlexBindevald
Copy link

I have the same problem in official website and in my project. Worked correctly in 4.1.1 version.

@AlexBindevald
Copy link

probably this commit broke it c2a5378

@AxelRothe
Copy link

Reorder is broken for me too. Doesn't work on the official website or my repos.

@ashokgelal
Copy link

Definitely broken

@liuchunlei-jpg
Copy link
Author

I didn't have any issue with the reorder. Can you please explain behavior you are observing?

Row drag sorting does not work

@liuchunlei-jpg
Copy link
Author

liuchunlei-jpg commented Feb 28, 2025

Found the point:
expect: enter true branch for svg
actual: enter false branch for svg

onRowMouseDown(event) {
if (getAttribute(event.target, 'data-pc-section') === 'reorderablerowhandle' || getAttribute(event.target.parentElement, 'data-pc-section') === 'reorderablerowhandle') event.currentTarget.draggable = true;
else event.currentTarget.draggable = false;
},

Fix PR: primefaces/primeuix#46

@brecht-vermeersch
Copy link

Temporary workaround

// package.json
  "resolutions": {
    "@primeuix/utils": "0.4.1"
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

6 participants