Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Galleria: Global ripple effect breaks Galleria #6438

Closed
ap-jirikralovec opened this issue Sep 19, 2024 · 0 comments
Closed

Galleria: Global ripple effect breaks Galleria #6438

ap-jirikralovec opened this issue Sep 19, 2024 · 0 comments
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.1.0

Comments

@ap-jirikralovec
Copy link

Describe the bug

When using global ripple effect, the Galleria component's navigation/close buttons are now styled as position: relative. This breaks the entire layout of Galleria:

image

Reproducer

https://stackblitz.com/edit/hheeak?file=src%2FApp.vue

PrimeVue version

4.0.5

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

  1. Setup a Vue project with PrimeVue
  2. Globally enable ripple as part of the theme
  3. Use Galleria component with full-screen
  4. The close button and navigation items are broken

Expected behavior

It is expected that the ripple effect will not break the component.
@ap-jirikralovec ap-jirikralovec added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 19, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 25, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.1.0 milestone Sep 25, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Sep 25, 2024
@github-staff github-staff deleted a comment from Kami-prog Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.1.0
Development

No branches or pull requests
2 participants
@tugcekucukoglu @ap-jirikralovec