Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button icon position does not switch sides when switching to RTL #17784

Open
2 of 4 tasks
aberonni opened this issue Feb 27, 2025 · 0 comments
Open
2 of 4 tasks

Button icon position does not switch sides when switching to RTL #17784

aberonni opened this issue Feb 27, 2025 · 0 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@aberonni
Copy link
Contributor

Describe the bug

Steps to reproduce

  1. Open the button documentation
  2. Use the theme switcher in the head to switch to RTL mode
  3. Obseve the icons on the buttons

Expected behaviour

The icons switch from left to right

Actual behaviour

The icons remain on the left

Notes

For other components (eg TabMenu) this works as expected.

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

I think this relates to a wider issue of having to hardcode left/right based on RTL, rather than using logical attributes - see feature request here: https://github.com/orgs/primefaces/discussions/3649

This makes it difficult for me to understand how best to contribute.

Reproducer

https://stackblitz.com/edit/vn3vacch?file=package.json

Environment

N/A

Angular version

19

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. Open the button documentation
  2. Use the theme switcher in the head to switch to RTL mode
  3. Obseve the icons on the buttons

Expected behavior

The icons on buttons where the position attribute has not been used switch from left to right.

@aberonni aberonni added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant