Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about iife wrapper #270

Open
samselikoff opened this issue Sep 13, 2019 · 2 comments
Open

Question about iife wrapper #270

samselikoff opened this issue Sep 13, 2019 · 2 comments

Comments

@samselikoff
Copy link
Contributor

Right now Pretender uses iife wrapper to use external deps in the project. Any particular reason for this or just legacy code? If legacy can we move to import syntax everywhere and have rollup produce iife on its own?

@xg-wang
Copy link
Member

xg-wang commented Sep 14, 2019

@stefanpenner knows fosure #96 :)

@givanse
Copy link
Contributor

givanse commented Oct 2, 2019

I strongly suspect that the reason why the iife wrapper has survived until now is ember-cli-pretender. What I think should happen is:

  • deprecate ember-cli-pretender, its not needed since you can import Pretender as an ES6 module
  • remove ember-cli-pretender
  • remove the iife

or similar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants