Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare adapter for full integration #66

Open
BenjaminRodenberg opened this issue Jul 1, 2021 · 1 comment
Open

Prepare adapter for full integration #66

BenjaminRodenberg opened this issue Jul 1, 2021 · 1 comment

Comments

@BenjaminRodenberg
Copy link
Member

Goal: inline in the actual ccx code using #ifdefs

Note: I copied this issue from our internal list of todos to make it more visible. Please feel free to directly edit the header, if you can provide more details on the rationale behind this approach. I guess that one reason is that maintaining the Makefile of this adapter is painful, but I'm overview of the CalculiX adapter.

@BenjaminRodenberg
Copy link
Member Author

unifdef might be a handy tool in this context. It allows to easily evaluate ifdefs and inline or remove the code inside of the ifdef-branch. Use-cases I have in mind:

  • When working on this issue one might start by checking the diff of the original and adapted CalculiX code and introduce ifdefs step-by-step until the diff is empty.
  • Check via a diff on the original CalculiX codebase that no code was added accidentally.
  • Set up a test that compares our fork of CalculiX + adapter to the latest CalculiX version. Then we will be able to detect upstream changes easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant