Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdPosition Enum un-matched definitions between Android and iOS #1111

Open
AbrahamArmasCordero opened this issue Feb 26, 2025 · 0 comments
Open

Comments

@AbrahamArmasCordero
Copy link
Contributor

AbrahamArmasCordero commented Feb 26, 2025

Describe the bug
Android has more Definitions for the Same Enum than iOS or Android has too many definitions Undefined in iOS does not exist

Android iOS
UNDEFINED(-1) HERE IS THE BUG
UNKNOWN(0) case undefined = 0
ABOVE_THE_FOLD(1) case aboveTheFold = 1
LOCKED(2) case locked = 2
BELOW_THE_FOLD(3) case belowTheFold = 3
HEADER(4) case header = 4
FOOTER(5) case footer = 5
SIDEBAR(6) case sidebar = 6
FULLSCREEN(7) case fullScreen = 7

also id 0 in android is "Unknown" and in ios is "Undefined"

To Reproduce
Steps to reproduce the behavior:
go to android file where this is defined https://github.com/prebid/prebid-mobile-android/blob/master/PrebidMobile/PrebidMobile-core/src/main/java/org/prebid/mobile/rendering/models/AdPosition.java#L36

and to iOS file where this is defined https://github.com/prebid/prebid-mobile-ios/blob/master/PrebidMobile/PrebidMobileRendering/AdPosition.swift#L33

Expected behavior
Both should have the same amount of values. Undefined in iOS should be id = -1 and add the Unknown value or if the problem is in android having too many values we should remove the appropiate value since idk if undefined it's just an option to null on the SDK

Using prebid 2.4.0 in both

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

1 participant