-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide Getter/Setter methods to the displaymanager
and displaymanagerver
objects
#672
Comments
Hi @takenorim ! Thanks for the report! #551 was not about removing the values but about sending only relevant ones. In the case of Original API, the Prebid SDK doesn't know anything about the rendering engine. It can be GMA SDK, IMA SDK, or custom SDK. So by default, the Prebid SDK should send nothing for these fields. As for me, providing publishers the ability to set these properties via SDK configs makes sense. It can be implemented in two ways:
Since we have the feature request for ORTB parameters, I'd suggest moving this way. It's more time-consuming, though.
@alexsavelyev @mmullin, the committee should prioritize and choose the implementation approach for this ticket. |
Hey @YuriyVelichko ! Thanks for your prompt feedback.
This way sounds reasonable. Either way, app developers need to upgrade Prebid SDK, change app source codes, re-build app, and push it to the app store. So, entire process will be time-consuming. Then, I believe more generic way (supporting oRTB params) would be preferable way for everyone.
Not yet. I'm waiting for feedback from my PBS team whether our production PBS cluster can support such custom oRTB objects at imp-level SRID. |
Hi @YuriyVelichko I have a client here who requested it too as they're seeing uplift in spend from some partners whenever this field is present in requests. Would we be able to prio it? |
@alexsavelyev @mmullin, we should discuss it on the next backlog grooming call. (Mon, Sep 4th) |
Hi @YuriyVelichko I also have a client who requested this as well for the same reason as @chakersaloumi calls out. Has there been any update on this? |
The last grooming call was on Labor Day, so we didn't get a quorum. |
This should be solved with prebid/prebid-mobile-ios#877 |
I know those objects are dropped intentionally per the #551. However, in terms of profitability, those OpenRTB objects are relevant to some bidders.
Default value (null for the Original API integration, hard-coded values (
prebid-mobile
and SDK version) for other integrations) is fine. But, it's worthwhile to app developers to have capability to setup those flags whatever they want.The text was updated successfully, but these errors were encountered: