Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the UI of the popover #3

Open
prateekkalra opened this issue May 1, 2018 · 17 comments
Open

Improve the UI of the popover #3

prateekkalra opened this issue May 1, 2018 · 17 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@prateekkalra
Copy link
Owner

No description provided.

@prateekkalra prateekkalra added help wanted Extra attention is needed good first issue Good for newcomers labels May 1, 2018
@bbenefield89
Copy link

I believe a good idea to improve the UI is to set title attribute on each "button" that accurately describes that buttons action. While the Facebook and Twitter buttons are a little self-explanatory I found myself unsure of what the other three would do.

If not a title attribute how about a smaller popover in the same style as the original popover?

@prateekkalra
Copy link
Owner Author

@bbenefield89 Thanks for your suggestion, I'll certainly take that into consideration.

@bbenefield89
Copy link

@prateekkalra Of course and if you have any ideas I wouldn't mind helping out.

@prateekkalra
Copy link
Owner Author

prateekkalra commented May 5, 2018

@bbenefield89 About your suggestion , I can't really come up with a way to tell users what each option stands for , because a 'pop over' over another 'pop over' won't look good . So if you got an idea, that could help me.

@bbenefield89
Copy link

bbenefield89 commented May 5, 2018

@prateekkalra Yea I didn't really like the "create another popover" idea either but if you were to add a title attribute with a short description, in my opinion, is easy to add and will give the user some direction as to what the button will do.

Examples

  • COPY: This icon is really similar to my phones "update security" notification. Adding a short description "Copy Text" or "Copy text to clipboard" could solve this.

  • SPEECH: This icon may seem more familiar to a user in terms of "I need to speak into a microphone" instead of "This will actually speak to me". This could also be solved by replacing the icon with something that resembles noise like this icon

@Thomdeleon
Copy link

@prateekkalra I wasn't sure if this issue was still open. I implemented the title attribute as suggested by bbenefield89. Please see the pull request. I also didn't update the minified file since I wasn't sure which program you used to minify it.

@prateekkalra
Copy link
Owner Author

@Thomdeleon This title attribute makes no difference to the user's look and feel(UI).
I was thinking of something which will help the user identify what each icon on the popover stands for, and I don't want to go for just a simple text as suggested by @bbenefield89.

@zackhitch
Copy link

Perhaps making the popover larger, with small text under each button indicating the use of each?

@Shai1436
Copy link

Shai1436 commented Jun 8, 2018

Can't we use tooltip for each icon? Something like this: tooltip demo
@prateekkalra Do you want complete sentences describing what each icon does?

@prateekkalra
Copy link
Owner Author

@Shai1436 Using tooltip won't be a good option as the tooltip would be shown every time whenever the user hovers over the option and the popover's UI won't be minimalistic anymore.
Showing the tooltip just for the first time user selects some text, can be considered though.

@Shai1436
Copy link

Shai1436 commented Jun 8, 2018

We could also replace some icons with simple text, just like selection option in android phones.

@hattifnatt4r
Copy link

Hello @prateekkalra, I would like to contribute.
How about adding 'help button' to the main popover? This button can open additional text field (like in 1st pic), or it can replace initial popover with the larger one that contains descriptions (2d pic).
selectjs_5-2 selectjs_6-2

@ankitverma2211
Copy link

@prateekkalra is anyone working on this ?

@saurabhnarhe
Copy link

Hello @prateekkalra, I would like to contribute.
I have done some simple work. Though not much changes but I think this looks clean and clear than the current one. Please have a look.

  • Current One ->

Screenshot_2019-04-30 Selection js(1)

  • My Changes ->

Screenshot_2019-04-30 Selection js

Thanks.

@BeardedBry
Copy link

I'm interested in contributing to this.

@BeardedBry
Copy link

@prateekkalra
How about a simple title attribute? It is built in to the browser and takes a moment before showing up!

selection-js

@MokhammadDaniyal
Copy link

@prateekkalra I have created a PR where I added a small pop up animation on selection #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

10 participants