Migrate to neutrino v9 (taskcluster#47)

* Migrate to neutrino v9

* Remove usage of neutrino-preset-mozilla-frontend-infra

* Regenerate yarn.lock

Author: helfi92

services/web-server/.eslintrc.js

@@ -1,5 +1,3 @@
-const { Neutrino } = require('neutrino');
+const neutrino = require('neutrino');
 
-module.exports = Neutrino({ root: __dirname })
-  .use('.neutrinorc')
-  .call('eslintrc');
+module.exports = neutrino().eslintrc();

services/web-server/.gitignore

@@ -5,3 +5,4 @@ node_modules
 .env
 .idea
 user-config.yml
+.eslintcache

services/web-server/.neutrinorc.js

@@ -1,40 +1,61 @@
 module.exports = {
   use: [
-    ['neutrino-preset-mozilla-frontend-infra/node', {
-      hot: false,
-      babel: {
-        plugins: [
-          require.resolve('babel-plugin-transform-object-rest-spread'),
-        ],
-      },
+    ['@neutrinojs/airbnb-base', {
       eslint: {
+        baseConfig: {
+          extends: ['eslint-config-prettier'],
+        },
+        plugins: ['eslint-plugin-prettier'],
         rules: {
-          'no-nested-ternary': 'off',
+          'no-nested-ternary': 0,
+          // Specify the maximum length of a line in your program
+          'max-len': [
+            'error',
+            80,
+            2,
+            {
+              ignoreUrls: true,
+              ignoreComments: false,
+              ignoreStrings: true,
+              ignoreTemplateLiterals: true,
+            },
+          ],
+          // Allow console during development, otherwise throw an error
+          'no-console': process.env.NODE_ENV === 'development' ? 'off' : 'error',
+          // Our frontend strives to adopt functional programming practices,
+          // so we prefer const over let
+          'prefer-const': 'error',
+          'prettier/prettier': [
+            'error',
+            {
+              singleQuote: true,
+              trailingComma: 'es5',
+              bracketSpacing: true,
+              jsxBracketSameLine: true,
+            },
+          ],
+          'class-methods-use-this': 'off',
+          'no-shadow': 'off',
+          'babel/new-cap': 'off',
         },
       },
     }],
-    // replace start-server with restart-server
-    (neutrino) => {
-      neutrino.config.when(neutrino.options.command === 'start', config => {
-        config.plugins.delete('start-server');
-        neutrino.use(['neutrino-middleware-restart-server', {
-          name: 'index.js',
-        }]);
-      });
-    },
+    ['@neutrinojs/node', {
+      hot: false,
+      babel: {
+        plugins: [
+          [require.resolve('@babel/plugin-proposal-decorators'), { legacy: true }],
+          require.resolve('@babel/plugin-proposal-class-properties'),
+        ]
+      },
+    }],
     (neutrino) => {
       neutrino.config.module
         .rule('graphql')
           .test(/\.graphql$/)
           .use('raw')
             .loader(require.resolve('raw-loader'));
     },
-    // work around https://bugzilla.mozilla.org/show_bug.cgi?id=1489273
-    (neutrino) => {
-      neutrino.config.when(neutrino.options.command === 'build', config => {
-        config.plugins.delete('named-chunks');
-      });
-    },
     '@neutrinojs/mocha'
   ],
 };

services/web-server/mocha.config.js

@@ -0,0 +1,3 @@
+process.env.NODE_ENV = process.env.NODE_ENV || 'test';
+
+require('neutrino')().mocha();

services/web-server/package.json

@@ -6,19 +6,28 @@
   "author": "Eli Perelman <[email protected]>",
   "license": "MPL-2.0",
   "scripts": {
-    "build": "neutrino build",
-    "start": "neutrino start",
-    "lint": "neutrino lint",
-    "precommit": "neutrino stage",
-    "test": "neutrino test"
+    "build": "webpack --mode production",
+    "start": "webpack --watch --mode development",
+    "lint": "eslint --cache --format codeframe --ext mjs,js src test",
+    "test": "mocha --require mocha.config.js --recursive"
   },
   "devDependencies": {
-    "@neutrinojs/mocha": "^8.3.0",
-    "neutrino": "^8.2.1",
-    "neutrino-preset-mozilla-frontend-infra": "^4.1.0",
-    "raw-loader": "^0.5.1"
+    "@babel/plugin-proposal-class-properties": "^7.1.0",
+    "@babel/plugin-proposal-decorators": "^7.1.2",
+    "@neutrinojs/airbnb-base": "^9.0.0-beta.0",
+    "@neutrinojs/mocha": "^9.0.0-beta.0",
+    "eslint": "^5.6.1",
+    "eslint-config-prettier": "^3.1.0",
+    "eslint-plugin-prettier": "^3.0.0",
+    "mocha": "^5.2.0",
+    "neutrino": "^9.0.0-beta.0",
+    "prettier": "^1.14.3",
+    "raw-loader": "^0.5.1",
+    "webpack": "^4.20.2",
+    "webpack-cli": "^3.1.2"
   },
   "dependencies": {
+    "@neutrinojs/node": "^9.0.0-beta.0",
     "amqp-match": "^0.0.0",
     "apollo-server-express": "^1.3.4",
     "async-decorators": "^0.1.5",
@@ -39,7 +48,6 @@
     "graphql-validation-complexity": "^0.2.3",
     "immutable": "^3.8.2",
     "iterall": "^1.2.2",
-    "neutrino-middleware-restart-server": "^1.0.1",
     "passport": "^0.4.0",
     "passport-github": "^1.1.0",
     "ramda": "^0.25.0",

services/web-server/src/createContext.js

@@ -17,7 +17,9 @@ export default ({ pulseEngine, rootUrl }) => ({ request, connection }) => {
       clients: currentClients,
       loaders: currentLoaders,
     };
-  } else if (connection) {
+  }
+
+  if (connection) {
     // if connection is set, this is for a subscription
     return {
       pulseEngine,

services/web-server/src/resolvers/Hooks.js

@@ -3,7 +3,9 @@ export default {
     __resolveType(obj) {
       if (obj.taskId) {
         return 'HookSuccessfulFire';
-      } else if (obj.error) {
+      }
+
+      if (obj.error) {
         return 'HookFailedFire';
       }
 

services/web-server/test/simple_test.js

@@ -5,4 +5,3 @@ describe('simple', () => {
     assert.equal(true, !false);
   });
 });
-

services/web-server/webpack.config.js

@@ -0,0 +1,3 @@
+const neutrino = require('neutrino');
+
+module.exports = neutrino().webpack();