Upgrade neutrino packages (taskcluster#59)

* Upgrade neutrino packages

* Use @mozilla-frontend-infra/node

Author: helfi92

services/web-server/.neutrinorc.js

@@ -1,43 +1,8 @@
 module.exports = {
   use: [
-    ['@neutrinojs/airbnb-base', {
-      eslint: {
-        baseConfig: {
-          extends: ['eslint-config-prettier'],
-        },
-        plugins: ['eslint-plugin-prettier'],
-        rules: {
-          'no-nested-ternary': 0,
-          // Specify the maximum length of a line in your program
-          'max-len': [
-            'error',
-            80,
-            2,
-            {
-              ignoreUrls: true,
-              ignoreComments: false,
-              ignoreStrings: true,
-              ignoreTemplateLiterals: true,
-            },
-          ],
-          // Allow console during development, otherwise throw an error
-          'no-console': process.env.NODE_ENV === 'development' ? 'off' : 'error',
-          // Our frontend strives to adopt functional programming practices,
-          // so we prefer const over let
-          'prefer-const': 'error',
-          'prettier/prettier': [
-            'error',
-            {
-              singleQuote: true,
-              trailingComma: 'es5',
-              bracketSpacing: true,
-              jsxBracketSameLine: true,
-            },
-          ],
-          'class-methods-use-this': 'off',
-          'no-shadow': 'off',
-          'babel/new-cap': 'off',
-        },
+    ['@mozilla-frontend-infra/node-lint', {
+      rules: {
+        'no-nested-ternary': 'off',
       },
     }],
     ['@neutrinojs/node', {

services/web-server/package.json

@@ -19,20 +19,20 @@
   "devDependencies": {
     "@babel/plugin-proposal-class-properties": "^7.1.0",
     "@babel/plugin-proposal-decorators": "^7.1.2",
-    "@neutrinojs/airbnb-base": "^9.0.0-beta.0",
-    "@neutrinojs/mocha": "^9.0.0-beta.0",
-    "eslint": "^5.6.1",
+    "@neutrinojs/mocha": "9.0.0-rc.0",
+    "@neutrinojs/node": "9.0.0-rc.0",
+    "eslint": "^5.10.0",
     "eslint-config-prettier": "^3.1.0",
     "eslint-plugin-prettier": "^3.0.0",
     "mocha": "^5.2.0",
-    "neutrino": "^9.0.0-beta.0",
+    "neutrino": "9.0.0-rc.0",
     "prettier": "^1.14.3",
     "raw-loader": "^0.5.1",
     "webpack": "^4.25.1",
     "webpack-cli": "^3.1.2"
   },
   "dependencies": {
-    "@neutrinojs/node": "^9.0.0-beta.0",
+    "@mozilla-frontend-infra/node-lint": "^1.1.1",
     "amqp-match": "^0.0.0",
     "apollo-server-express": "^1.3.4",
     "async-decorators": "^0.1.5",

services/web-server/src/PulseEngine/EventIterator.js

@@ -14,6 +14,7 @@ export default class EventIterator {
   async next() {
     const { value, done } = await this.messageIterator.next();
     const event = { [this.eventName]: value.payload };
+
     return { value: event, done };
   }
 

services/web-server/src/PulseEngine/MessageIterator.js

@@ -14,6 +14,7 @@ export default class MessageIterator {
   async next() {
     const { value, done } = await this.messageIterator.next();
     const event = { [this.eventName]: value };
+
     return { value: event, done };
   }
 

services/web-server/src/index.js

@@ -56,6 +56,7 @@ const load = loader(
           console.log(
             `\n\nNo Pulse namespace defined; no Pulse messages will be received.`
           );
+
           return new FakeClient();
         }
 

services/web-server/src/utils/fetch.js

@@ -14,11 +14,10 @@ const defaults = {
 };
 const handleResponse = response =>
   Promise.resolve(response)
-    .then(
-      () =>
-        JSON_CONTENT.test(response.headers.get('Content-Type'))
-          ? response.json()
-          : null
+    .then(() =>
+      JSON_CONTENT.test(response.headers.get('Content-Type'))
+        ? response.json()
+        : null
     )
     .then(json => {
       if (response.ok) {
@@ -47,7 +46,6 @@ export default (url, opts = {}) => {
       ...opts.headers,
     },
   };
-
   const { delayFactor, randomizationFactor, maxDelay, retries } = options;
 
   return new Promise((resolve, reject) => {

services/web-server/test/fetch_test.js

@@ -14,8 +14,10 @@ describe('fetch', () => {
 
   it('should retry a 500', () => {
     let attemptCount = 0;
+
     server = createServer((req, res) => {
       attemptCount += 1;
+
       if (attemptCount < 2) {
         res.writeHead(500);
         res.end();