feat(query): add useQueriesState composable
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for funny-banoffee-0afb46 canceled.
|
quiteeasy
reviewed
May 22, 2024
| @@ -173,7 +173,7 @@ export const useQueryCache = defineStore(QUERY_STORE_ID, () => { | |||
|
|
|||
| function ensureEntry<TResult = unknown, TError = ErrorDefault>( | |||
| keyRaw: EntryKey, | |||
| options: UseQueryOptionsWithDefaults<TResult, TError>, | |||
| options?: UseQueryOptionsWithDefaults<TResult, TError>, | |||
There was a problem hiding this comment.
Creating a query entry without options risks errors if the key is invalidated and the options are accessed. Probably, we should consider avoiding creating query entities in UseQueryState and return undefined/null instead.
| return keys.map<QueryState[]>( | ||
| // TODO: fix TS issue | ||
| (key) => { | ||
| const query = ensureEntry(toValue(key)) |
There was a problem hiding this comment.
Should we add and use the findQuery function here? It will work if we decide not to create a query in useQueriesState in case it has not been created
| import type { QueryStatus } from './query-store' | ||
| import { useQueryCache } from './query-store' | ||
|
|
||
| interface QueryState { |
There was a problem hiding this comment.
Can we use _UseQueryEntry_State type from query-store.ts here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.