Skip to content

Commit a88d3ec

Browse files
committed
relplace settings alert with a notification WordPress style #220
1 parent 78e0f24 commit a88d3ec

File tree

3 files changed

+15
-4
lines changed

3 files changed

+15
-4
lines changed

assets/js/epoch-admin.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jQuery( document ).ready( function ( $ ) {
77
var $spinner = $( '#epoch-spinner');
88
$spinner.attr( 'aria-hidden', false ).show().css( 'visibility', 'visible' );
99
var infinity = document.getElementById('epoch-infinity_scroll').checked;
10-
10+
$( '.epoch-settings-indicator' ).hide().css( 'visibility', 'hidden' ).attr( 'aria-hidden', true );
1111
var data = {
1212
order: $( '#epoch-order' ).val(),
1313
per_page: $( '#epoch-per_page' ).val(),
@@ -18,9 +18,9 @@ jQuery( document ).ready( function ( $ ) {
1818
action: "epoch_settings"
1919
};
2020
$.post( ajaxurl, data ).done( function () {
21-
alert( EpochAdmin.saved );
21+
$( '#epoch-saved-good' ).attr( 'aria-hidden', false ).show().css( 'visibility', 'visible' );
2222
}).error( function () {
23-
alert( EpochAdmin.error );
23+
$( '#epoch-saved-bad' ).attr( 'aria-hidden', false ).show().css( 'visibility', 'visible' );
2424
}).always( function () {
2525
$spinner.attr( 'aria-hidden', true ).hide().css( 'visibility', 'hidden' );
2626
})

assets/templates/admin-screen.php

+11-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,17 @@
1414
?>
1515
<div id="epoch-admin">
1616
<div id="epoch-admin-header">
17-
HEADER
17+
HEADER - Hi Jason:)
18+
</div>
19+
<div id="epoch-saved-good" class="epoch-settings-indicator" style="display: none;visibility: hidden;" aria-hidden="true">
20+
<p class="notice notice-success">
21+
<?php esc_html_e( 'Settings Saved Successfully', 'epoch' ); ?>
22+
</p>
23+
</div>
24+
<div id="epoch-saved-bad" class="epoch-settings-indicator" style="display: none;visibility: hidden;" aria-hidden="true">
25+
<p class="notice notice-error">
26+
<?php esc_html_e( 'Settings Could Not Be Saved.', 'epoch' ); ?>
27+
</p>
1828
</div>
1929
<form id="epoch-admin-settings">
2030
<div class="epoch-field-group">

src/admin/save.php

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ public function save_settings(){
3333
}
3434
}
3535
}
36+
3637
status_header( 201 );
3738
echo update_option( $this->option_key, $data );
3839
exit;

0 commit comments

Comments
 (0)