Skip to content

Commit a3417c4

Browse files
committed
Fix performance.now()
1 parent 756e8aa commit a3417c4

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

request.js

+8-9
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ var safeStringify = helpers.safeStringify
3939
var isReadStream = helpers.isReadStream
4040
var toBase64 = helpers.toBase64
4141
var defer = helpers.defer
42-
var now = performance.now // eslint-disable-line
4342
var copy = helpers.copy
4443
var version = helpers.version
4544
var SizeTrackerStream = helpers.SizeTrackerStream
@@ -930,11 +929,11 @@ Request.prototype.start = function () {
930929
if (self.timing) {
931930
// All timings will be relative to this request's startTime. In order to do this,
932931
// we need to capture the wall-clock start time (via Date), immediately followed
933-
// by the high-resolution timer (via now()). While these two won't be set
932+
// by the high-resolution timer (performance.now()). While these two won't be set
934933
// at the _exact_ same time, they should be close enough to be able to calculate
935934
// high-resolution, monotonically non-decreasing timestamps relative to startTime.
936935
var startTime = new Date().getTime()
937-
var startTimeNow = now()
936+
var startTimeNow = performance.now()
938937
}
939938

940939
if (self._aborted) {
@@ -1050,15 +1049,15 @@ Request.prototype.start = function () {
10501049
// `._connecting` was the old property which was made public in node v6.1.0
10511050
var isConnecting = socket._connecting || socket.connecting
10521051
if (self.timing) {
1053-
self.timings.socket = now() - self.startTimeNow
1052+
self.timings.socket = performance.now() - self.startTimeNow
10541053

10551054
if (isConnecting) {
10561055
var onLookupTiming = function () {
1057-
self.timings.lookup = now() - self.startTimeNow
1056+
self.timings.lookup = performance.now() - self.startTimeNow
10581057
}
10591058

10601059
var onConnectTiming = function () {
1061-
self.timings.connect = now() - self.startTimeNow
1060+
self.timings.connect = performance.now() - self.startTimeNow
10621061

10631062
if (self.verbose) {
10641063
socket.__SESSION_DATA.addresses = {
@@ -1078,7 +1077,7 @@ Request.prototype.start = function () {
10781077
}
10791078

10801079
var onSecureConnectTiming = function () {
1081-
self.timings.secureConnect = now() - self.startTimeNow
1080+
self.timings.secureConnect = performance.now() - self.startTimeNow
10821081

10831082
if (self.verbose) {
10841083
socket.__SESSION_DATA.tls = {
@@ -1257,13 +1256,13 @@ Request.prototype.onRequestResponse = function (response) {
12571256
const requestSegmentStartTime = self.startTimeNow
12581257

12591258
if (self.timing) {
1260-
self.timings.response = now() - requestSegmentStartTime
1259+
self.timings.response = performance.now() - requestSegmentStartTime
12611260
}
12621261

12631262
debug('onRequestResponse', self.uri.href, response.statusCode, response.headers)
12641263
response.on('end', function () {
12651264
if (self.timing) {
1266-
self.timings.end = now() - requestSegmentStartTime
1265+
self.timings.end = performance.now() - requestSegmentStartTime
12671266
response.timingStart = self.startTime
12681267
response.timingStartTimer = requestSegmentStartTime
12691268

0 commit comments

Comments
 (0)