Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix React ESLint errors #6307

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Fix React ESLint errors #6307

merged 3 commits into from
Feb 11, 2025

Conversation

softwarenerd
Copy link
Contributor

@softwarenerd softwarenerd commented Feb 11, 2025 •
edited
Loading

Description

This PR fixes React ESLint errors caused by the following rules:

react-hooks/rules-of-hooks
react-hooks/exhaustive-deps
react/jsx-sort-props

To verify that everything has been addressed, you can execute:

npx eslint **/*.tsx --quiet

Tests:
@:all @:web @:win

Release Notes

New Features

  • N/A

Bug Fixes

  • N/A

QA Notes

  • N/A

@github-actions GitHub Actions
Copy link

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

jmcphers
jmcphers approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@jmcphers jmcphers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, compiled and linted locally w/o issue!

dhruvisompura
dhruvisompura approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@dhruvisompura dhruvisompura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into the datagrid linting failures! This is looking great

@softwarenerd
Copy link
Contributor Author

LGTM, compiled and linted locally w/o issue!

Thank you!

@softwarenerd
Copy link
Contributor Author

Thanks for looking into the datagrid linting failures! This is looking great

Thank you!

@softwarenerd softwarenerd merged commit ef8e77c into main Feb 11, 2025
17 of 22 checks passed
@softwarenerd softwarenerd deleted the fix/sort-react-props branch February 11, 2025 23:58
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmcphers jmcphers jmcphers approved these changes

@dhruvisompura dhruvisompura dhruvisompura approved these changes

@sharon-wang sharon-wang Awaiting requested review from sharon-wang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@softwarenerd @jmcphers @dhruvisompura