Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Roslyn packages to their latest version #814

Open
bash opened this issue Jan 21, 2025 · 0 comments
Open

Update Roslyn packages to their latest version #814

bash opened this issue Jan 21, 2025 · 0 comments
Labels
area: DiscriminatedUnion Issues for Funcky.DiscriminateUnion breaking change These are change in a way that is not API-compatible to discuss There are open points which need to be discussed

Comments

@bash
Copy link
Member

bash commented Jan 21, 2025

This is a breaking change because it means that the source generator only runs on newer versions of the .NET SDK and Visual Studio.

There's a handy table that maps Roslyn package version to VS version. Then there's a second table that maps .NET SDK versions to VS versions.

I would like to update to 4.3.1 at minimum because that's the version that introduces context.SyntaxProvider.ForAttributeWithMetadataName.

If we still want to support the .NET 8 SDK, we can update to 4.11.0 at max. We'd support Visual Studio 2022 version 17.11 and upwards.
@bash bash added area: DiscriminatedUnion Issues for Funcky.DiscriminateUnion breaking change These are change in a way that is not API-compatible labels Jan 21, 2025
@bash bash mentioned this issue Jan 21, 2025
Open
@bash bash added the to discuss There are open points which need to be discussed label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: DiscriminatedUnion Issues for Funcky.DiscriminateUnion breaking change These are change in a way that is not API-compatible to discuss There are open points which need to be discussed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bash