Adds command 'spo page section remove'. Closes #6541 #6606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, we'll try to review it ASAP. |
martinlingstuyl
requested changes
Feb 26, 2025
There was a problem hiding this comment.
Hi @mkm17, Looks good to me. Do check out my comment.
Also: I assume we cannot delete verticalSections like this. Should we add a --verticalSection option here? Changing the spec slightly, or should we add it later?
| options: Options; | ||
| } | ||
|
|
||
| interface Options extends GlobalOptions { |
There was a problem hiding this comment.
Could you maybe refactor this setup to our newer setup with zod? Checkout other commands that have zod implementations for inspiration!
|
Also: could you rebase on the latest main and fix any merge conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds command 'spo page section remove'. Closes #6541