Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always translate server-side #6626

Open
dktapps opened this issue Feb 14, 2025 · 0 comments
Open

Always translate server-side #6626

dktapps opened this issue Feb 14, 2025 · 0 comments
Labels
Category: Network Related to the internal network architecture Category: UI Related to the user interface (e.g. commands, terminal output) Type: Cleanup Removes or deprecates API methods or behaviour Type: Enhancement Contributes features or other improvements to PocketMine-MP

Comments

@dktapps
Copy link
Member

dktapps commented Feb 14, 2025

Problem description

We currently rely on the client to translate strings presumed to be present in the vanilla files (anything not prefixed with pocketmine.).
We also don't take any information from the client about its selected language.

This is problematic for a few reasons

Proposed solution

We should use the locale provided in LoginPacket to decide the server-side language used to translate messages.
However, this is tricky due to the different codes used (we use 3-letter codes like eng while the client uses locale codes like en_US).

This is really two issues in one, but we can't do fully server-sided translation without tying it to client-provided locale.

Alternative solutions or workarounds

No response

@dktapps dktapps added Category: Network Related to the internal network architecture Category: UI Related to the user interface (e.g. commands, terminal output) Type: Cleanup Removes or deprecates API methods or behaviour Type: Enhancement Contributes features or other improvements to PocketMine-MP labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Network Related to the internal network architecture Category: UI Related to the user interface (e.g. commands, terminal output) Type: Cleanup Removes or deprecates API methods or behaviour Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Development

No branches or pull requests

1 participant