Skip to content

Commit 2c36d38

Browse files
author
Lenz Weber
committed
remove eagerness of RefreshUtils to reduce circular dependency errors
1 parent b9adfd2 commit 2c36d38

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

lib/runtime/RefreshUtils.js

+14
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,11 @@ function getReactRefreshBoundarySignature(moduleExports) {
5555
continue;
5656
}
5757

58+
59+
if (key[0] != key[0].toUpperCase()) {
60+
continue;
61+
}
62+
5863
signature.push(key);
5964
signature.push(Refresh.getFamilyByType(moduleExports[key]));
6065
}
@@ -117,6 +122,11 @@ function isReactRefreshBoundary(moduleExports) {
117122
continue;
118123
}
119124

125+
if (key[0] != key[0].toUpperCase()) {
126+
areAllExportsComponents = false;
127+
continue;
128+
}
129+
120130
// We can (and have to) safely execute getters here,
121131
// as Webpack manually assigns harmony exports to getters,
122132
// without any side-effects attached.
@@ -155,6 +165,10 @@ function registerExportsForReactRefresh(moduleExports, moduleId) {
155165
continue;
156166
}
157167

168+
if (key[0] != key[0].toUpperCase()) {
169+
continue;
170+
}
171+
158172
var exportValue = moduleExports[key];
159173
if (Refresh.isLikelyComponentType(exportValue)) {
160174
var typeID = moduleId + ' %exports% ' + key;

0 commit comments

Comments
 (0)